From 625ad667d0c0c17d5bc11d505f04861d90b45078 Mon Sep 17 00:00:00 2001 From: weili Date: Wed, 15 Jun 2016 11:21:33 -0700 Subject: Make code compile with clang_use_chrome_plugin (part IV) This change mainly contains files in fpdfsdk/ directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups plus removing an unused file and splitting cxfa_eventparam out from fxfa.h BUG=pdfium:469 Review-Url: https://codereview.chromium.org/2062313002 --- xfa/fxfa/app/cxfa_eventparam.cpp | 48 +++++++++++++++++++++++++++++++++++++++ xfa/fxfa/app/xfa_ffchoicelist.cpp | 1 + xfa/fxfa/app/xfa_ffnotify.h | 1 + xfa/fxfa/app/xfa_fftextedit.cpp | 1 + xfa/fxfa/app/xfa_ffwidget.cpp | 2 ++ xfa/fxfa/app/xfa_ffwidgetacc.cpp | 1 + 6 files changed, 54 insertions(+) create mode 100644 xfa/fxfa/app/cxfa_eventparam.cpp (limited to 'xfa/fxfa/app') diff --git a/xfa/fxfa/app/cxfa_eventparam.cpp b/xfa/fxfa/app/cxfa_eventparam.cpp new file mode 100644 index 0000000000..5f9d752969 --- /dev/null +++ b/xfa/fxfa/app/cxfa_eventparam.cpp @@ -0,0 +1,48 @@ +// Copyright 2016 PDFium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com + +#include "xfa/fxfa/include/cxfa_eventparam.h" + +#include "xfa/fxfa/include/fxfa.h" + +CXFA_EventParam::CXFA_EventParam() + : m_pTarget(nullptr), + m_eType(XFA_EVENT_Unknown), + m_bCancelAction(FALSE), + m_iCommitKey(0), + m_bKeyDown(FALSE), + m_bModifier(FALSE), + m_bReenter(FALSE), + m_iSelEnd(0), + m_iSelStart(0), + m_bShift(FALSE), + m_bIsFormReady(FALSE), + m_iValidateActivities(XFA_VALIDATE_preSubmit) {} + +CXFA_EventParam::~CXFA_EventParam() {} + +CXFA_EventParam::CXFA_EventParam(const CXFA_EventParam& other) = default; + +void CXFA_EventParam::Reset() { + m_wsChange.clear(); + m_bCancelAction = FALSE; + m_iCommitKey = 0; + m_wsFullText.clear(); + m_bKeyDown = FALSE; + m_bModifier = FALSE; + m_wsNewContentType.clear(); + m_wsNewText.clear(); + m_wsPrevContentType.clear(); + m_wsPrevText.clear(); + m_bReenter = FALSE; + m_iSelEnd = 0; + m_iSelStart = 0; + m_bShift = FALSE; + m_wsSoapFaultCode.clear(); + m_wsSoapFaultString.clear(); + m_bIsFormReady = FALSE; + m_iValidateActivities = XFA_VALIDATE_preSubmit; +} diff --git a/xfa/fxfa/app/xfa_ffchoicelist.cpp b/xfa/fxfa/app/xfa_ffchoicelist.cpp index 4258eef29b..4987b5ba23 100644 --- a/xfa/fxfa/app/xfa_ffchoicelist.cpp +++ b/xfa/fxfa/app/xfa_ffchoicelist.cpp @@ -13,6 +13,7 @@ #include "xfa/fwl/lightwidget/cfwl_listbox.h" #include "xfa/fxfa/app/xfa_fffield.h" #include "xfa/fxfa/app/xfa_fwladapter.h" +#include "xfa/fxfa/include/cxfa_eventparam.h" #include "xfa/fxfa/include/xfa_ffdoc.h" #include "xfa/fxfa/include/xfa_ffdocview.h" #include "xfa/fxfa/include/xfa_ffpageview.h" diff --git a/xfa/fxfa/app/xfa_ffnotify.h b/xfa/fxfa/app/xfa_ffnotify.h index 6dd400859b..e9e8721df3 100644 --- a/xfa/fxfa/app/xfa_ffnotify.h +++ b/xfa/fxfa/app/xfa_ffnotify.h @@ -7,6 +7,7 @@ #ifndef XFA_FXFA_APP_XFA_FFNOTIFY_H_ #define XFA_FXFA_APP_XFA_FFNOTIFY_H_ +#include "xfa/fxfa/include/cxfa_eventparam.h" #include "xfa/fxfa/parser/xfa_document.h" class CXFA_FFWidgetHandler; diff --git a/xfa/fxfa/app/xfa_fftextedit.cpp b/xfa/fxfa/app/xfa_fftextedit.cpp index 35ed84810f..171fe8dd36 100644 --- a/xfa/fxfa/app/xfa_fftextedit.cpp +++ b/xfa/fxfa/app/xfa_fftextedit.cpp @@ -17,6 +17,7 @@ #include "xfa/fxfa/app/xfa_fffield.h" #include "xfa/fxfa/app/xfa_fwladapter.h" #include "xfa/fxfa/app/xfa_textlayout.h" +#include "xfa/fxfa/include/cxfa_eventparam.h" #include "xfa/fxfa/include/xfa_ffapp.h" #include "xfa/fxfa/include/xfa_ffdoc.h" #include "xfa/fxfa/include/xfa_ffdocview.h" diff --git a/xfa/fxfa/app/xfa_ffwidget.cpp b/xfa/fxfa/app/xfa_ffwidget.cpp index fb9ab5f580..fb4dc8ea6b 100644 --- a/xfa/fxfa/app/xfa_ffwidget.cpp +++ b/xfa/fxfa/app/xfa_ffwidget.cpp @@ -13,6 +13,8 @@ #include "core/fxcodec/codec/include/ccodec_progressivedecoder.h" #include "core/fxcodec/include/fx_codec.h" #include "xfa/fxfa/app/xfa_textlayout.h" +#include "xfa/fxfa/include/fxfa_widget.h" +#include "xfa/fxfa/include/cxfa_eventparam.h" #include "xfa/fxfa/include/xfa_ffapp.h" #include "xfa/fxfa/include/xfa_ffdoc.h" #include "xfa/fxfa/include/xfa_ffdocview.h" diff --git a/xfa/fxfa/app/xfa_ffwidgetacc.cpp b/xfa/fxfa/app/xfa_ffwidgetacc.cpp index 6a4a1f4f6f..9eeccdbb44 100644 --- a/xfa/fxfa/app/xfa_ffwidgetacc.cpp +++ b/xfa/fxfa/app/xfa_ffwidgetacc.cpp @@ -17,6 +17,7 @@ #include "xfa/fxfa/app/xfa_fffield.h" #include "xfa/fxfa/app/xfa_fwladapter.h" #include "xfa/fxfa/app/xfa_textlayout.h" +#include "xfa/fxfa/include/cxfa_eventparam.h" #include "xfa/fxfa/include/xfa_ffapp.h" #include "xfa/fxfa/include/xfa_ffdoc.h" #include "xfa/fxfa/include/xfa_ffdocview.h" -- cgit v1.2.3