From 36a8c861ea7a77ceb018ea4a494ae497d39437e5 Mon Sep 17 00:00:00 2001
From: Ryan Harrison <rharrison@chromium.org>
Date: Wed, 25 Apr 2018 21:52:04 +0000
Subject: Use local for return value in factory method

Follow requested in review after submit.

BUG=chromium:835608

Change-Id: I958a35f1cdaadbdb21e7c86b8c5b297ef01a2503
Reviewed-on: https://pdfium-review.googlesource.com/31316
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
---
 xfa/fxfa/cxfa_ffapp.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'xfa/fxfa/cxfa_ffapp.cpp')

diff --git a/xfa/fxfa/cxfa_ffapp.cpp b/xfa/fxfa/cxfa_ffapp.cpp
index 67a7270824..a2b0c005f0 100644
--- a/xfa/fxfa/cxfa_ffapp.cpp
+++ b/xfa/fxfa/cxfa_ffapp.cpp
@@ -53,9 +53,9 @@ CFGAS_FontMgr* CXFA_FFApp::GetFDEFontMgr() {
 
 CXFA_FWLTheme* CXFA_FFApp::GetFWLTheme() {
   if (!m_pFWLTheme) {
-    m_pFWLTheme = pdfium::MakeUnique<CXFA_FWLTheme>(this);
-    if (!m_pFWLTheme->LoadCalendarFont())
-      m_pFWLTheme = nullptr;
+    auto fwl_theme = pdfium::MakeUnique<CXFA_FWLTheme>(this);
+    if (fwl_theme->LoadCalendarFont())
+      m_pFWLTheme = std::move(fwl_theme);
   }
   return m_pFWLTheme.get();
 }
-- 
cgit v1.2.3