From 36261b631e1847bcfdda6d381ae414c954d73e88 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 21 Nov 2017 21:54:40 +0000 Subject: Cleanup CXFA_LineData Make methods const and return the correct types. Change-Id: Icaa1c17d611a69227f67ea398e4b3cc17bc1004b Reviewed-on: https://pdfium-review.googlesource.com/19011 Reviewed-by: Henrique Nakashima Commit-Queue: dsinclair --- xfa/fxfa/cxfa_ffline.cpp | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'xfa/fxfa/cxfa_ffline.cpp') diff --git a/xfa/fxfa/cxfa_ffline.cpp b/xfa/fxfa/cxfa_ffline.cpp index 62a4f86998..df83fa62ab 100644 --- a/xfa/fxfa/cxfa_ffline.cpp +++ b/xfa/fxfa/cxfa_ffline.cpp @@ -15,7 +15,7 @@ CXFA_FFLine::CXFA_FFLine(CXFA_WidgetAcc* pDataAcc) : CXFA_FFDraw(pDataAcc) {} CXFA_FFLine::~CXFA_FFLine() {} void CXFA_FFLine::GetRectFromHand(CFX_RectF& rect, - int32_t iHand, + XFA_ATTRIBUTEENUM iHand, float fLineWidth) { float fHalfWidth = fLineWidth / 2.0f; if (rect.height < 1.0f) { @@ -25,6 +25,11 @@ void CXFA_FFLine::GetRectFromHand(CFX_RectF& rect, break; case XFA_ATTRIBUTEENUM_Right: rect.top += fHalfWidth; + case XFA_ATTRIBUTEENUM_Even: + break; + default: + NOTREACHED(); + break; } } else if (rect.width < 1.0f) { switch (iHand) { @@ -34,6 +39,11 @@ void CXFA_FFLine::GetRectFromHand(CFX_RectF& rect, case XFA_ATTRIBUTEENUM_Right: rect.left += fHalfWidth; break; + case XFA_ATTRIBUTEENUM_Even: + break; + default: + NOTREACHED(); + break; } } else { switch (iHand) { @@ -43,6 +53,11 @@ void CXFA_FFLine::GetRectFromHand(CFX_RectF& rect, case XFA_ATTRIBUTEENUM_Right: rect.Deflate(fHalfWidth, fHalfWidth); break; + case XFA_ATTRIBUTEENUM_Even: + break; + default: + NOTREACHED(); + break; } } } -- cgit v1.2.3