From caf6d61fbb38083f213a9d3441e12c5082d3ad3a Mon Sep 17 00:00:00 2001 From: Nicolas Pena Date: Thu, 29 Jun 2017 17:02:48 -0400 Subject: Move Start to constructor in CFX_Image(Renderer|Transformer) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bool returned by Start was not being used and the method was always called right after the constructor, so it should be in the constructor. Change-Id: I98abf9f7c11fbe42b3aa15ec5e46731198aa23d5 Reviewed-on: https://pdfium-review.googlesource.com/7151 Commit-Queue: Nicolás Peña Reviewed-by: Lei Zhang --- xfa/fxfa/cxfa_ffwidget.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'xfa/fxfa/cxfa_ffwidget.cpp') diff --git a/xfa/fxfa/cxfa_ffwidget.cpp b/xfa/fxfa/cxfa_ffwidget.cpp index f72b29127a..2437c53cd3 100644 --- a/xfa/fxfa/cxfa_ffwidget.cpp +++ b/xfa/fxfa/cxfa_ffwidget.cpp @@ -660,15 +660,12 @@ bool CXFA_ImageRenderer::StartDIBSource() { m_Status = 2; m_pTransformer = pdfium::MakeUnique( pDib, &m_ImageMatrix, m_Flags, &clip_box); - m_pTransformer->Start(); return true; } - if (m_ImageMatrix.a < 0) { + if (m_ImageMatrix.a < 0) dest_width = -dest_width; - } - if (m_ImageMatrix.d > 0) { + if (m_ImageMatrix.d > 0) dest_height = -dest_height; - } int dest_left, dest_top; dest_left = dest_width > 0 ? image_rect.left : image_rect.right; dest_top = dest_height > 0 ? image_rect.top : image_rect.bottom; -- cgit v1.2.3