From cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9 Mon Sep 17 00:00:00 2001 From: tsepez Date: Mon, 16 May 2016 13:21:03 -0700 Subject: Remove { delete this; } anti-pattern from IXFA_WidgetIterator Review-Url: https://codereview.chromium.org/1976123003 --- xfa/fxfa/include/xfa_ffpageview.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'xfa/fxfa/include/xfa_ffpageview.h') diff --git a/xfa/fxfa/include/xfa_ffpageview.h b/xfa/fxfa/include/xfa_ffpageview.h index 75e418b25b..79b0afb602 100644 --- a/xfa/fxfa/include/xfa_ffpageview.h +++ b/xfa/fxfa/include/xfa_ffpageview.h @@ -36,12 +36,11 @@ class CXFA_FFPageView : public CXFA_ContainerLayoutItem { typedef CXFA_NodeIteratorTemplate CXFA_LayoutItemIterator; + class CXFA_FFPageWidgetIterator : public IXFA_WidgetIterator { public: CXFA_FFPageWidgetIterator(CXFA_FFPageView* pPageView, uint32_t dwFilter); - virtual ~CXFA_FFPageWidgetIterator(); - - void Release() override { delete this; } + ~CXFA_FFPageWidgetIterator() override; void Reset() override; CXFA_FFWidget* MoveToFirst() override; @@ -73,9 +72,7 @@ class CXFA_FFTabOrderPageWidgetIterator : public IXFA_WidgetIterator { public: CXFA_FFTabOrderPageWidgetIterator(CXFA_FFPageView* pPageView, uint32_t dwFilter); - virtual ~CXFA_FFTabOrderPageWidgetIterator(); - - void Release() override; + ~CXFA_FFTabOrderPageWidgetIterator() override; void Reset() override; CXFA_FFWidget* MoveToFirst() override; -- cgit v1.2.3