From 68c77592f25f9173d2166fa01fb34b4155f4cfcb Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Mon, 20 Nov 2017 20:27:43 +0000 Subject: Remove {Set|Get|Try}Object methods The CJX_Node::{Set|Get|Try}Object methods are used to set CXFA_WidgetData and CXFA_Node objects into the CJX_Node. This is stored in the node as void* data and custom delete methods are passed when needed. Instead, this CL just stores the two types of things we need on the CJX_Node and returns the correct types. This uses a bit more space on the CJX_Node, but it makes the code a lot clearer and simpler. Change-Id: I8546ea6456a1c1f5f8b602a6a420a0e85f3fac29 Reviewed-on: https://pdfium-review.googlesource.com/18570 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- xfa/fxfa/parser/cxfa_datadata.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'xfa/fxfa/parser/cxfa_datadata.h') diff --git a/xfa/fxfa/parser/cxfa_datadata.h b/xfa/fxfa/parser/cxfa_datadata.h index 5be86c28ab..a05b5024fe 100644 --- a/xfa/fxfa/parser/cxfa_datadata.h +++ b/xfa/fxfa/parser/cxfa_datadata.h @@ -17,7 +17,8 @@ class CXFA_DataData { public: static FX_ARGB ToColor(const WideStringView& wsValue); - explicit CXFA_DataData(CXFA_Node* pNode) : m_pNode(pNode) {} + explicit CXFA_DataData(CXFA_Node* pNode); + virtual ~CXFA_DataData(); explicit operator bool() const { return !!m_pNode; } CXFA_Node* GetNode() const { return m_pNode; } -- cgit v1.2.3