From b066704a22ba4f242567f508c12bf2545cbed9e1 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 16 Nov 2017 13:42:49 +0000 Subject: Convert TryCData and TryContent to optionals This CL changes the TryCData and TryContent to return pdfium::Optional values instead of returning a bool and taking an out WideString. Change-Id: I9c9d877803f9f1977191e12d6a907c29784c10b2 Reviewed-on: https://pdfium-review.googlesource.com/18510 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- xfa/fxfa/parser/cxfa_fontdata.cpp | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) (limited to 'xfa/fxfa/parser/cxfa_fontdata.cpp') diff --git a/xfa/fxfa/parser/cxfa_fontdata.cpp b/xfa/fxfa/parser/cxfa_fontdata.cpp index 87bea1714f..afe73538c8 100644 --- a/xfa/fxfa/parser/cxfa_fontdata.cpp +++ b/xfa/fxfa/parser/cxfa_fontdata.cpp @@ -20,25 +20,22 @@ float CXFA_FontData::GetBaselineShift() { } float CXFA_FontData::GetHorizontalScale() { - WideString wsValue; - m_pNode->JSNode()->TryCData(XFA_Attribute::FontHorizontalScale, wsValue, - true); + WideString wsValue = + m_pNode->JSNode()->GetCData(XFA_Attribute::FontHorizontalScale); int32_t iScale = FXSYS_wtoi(wsValue.c_str()); return iScale > 0 ? (float)iScale : 100.0f; } float CXFA_FontData::GetVerticalScale() { - WideString wsValue; - m_pNode->JSNode()->TryCData(XFA_Attribute::FontVerticalScale, wsValue, true); + WideString wsValue = + m_pNode->JSNode()->GetCData(XFA_Attribute::FontVerticalScale); int32_t iScale = FXSYS_wtoi(wsValue.c_str()); return iScale > 0 ? (float)iScale : 100.0f; } float CXFA_FontData::GetLetterSpacing() { - WideString wsValue; - if (!m_pNode->JSNode()->TryCData(XFA_Attribute::LetterSpacing, wsValue, true)) - return 0; - + WideString wsValue = + m_pNode->JSNode()->GetCData(XFA_Attribute::LetterSpacing); CXFA_Measurement ms(wsValue.AsStringView()); if (ms.GetUnit() == XFA_Unit::Em) return ms.GetValue() * GetFontSize(); @@ -70,7 +67,7 @@ float CXFA_FontData::GetFontSize() { } void CXFA_FontData::GetTypeface(WideString& wsTypeFace) { - m_pNode->JSNode()->TryCData(XFA_Attribute::Typeface, wsTypeFace, true); + wsTypeFace = m_pNode->JSNode()->GetCData(XFA_Attribute::Typeface); } bool CXFA_FontData::IsBold() { -- cgit v1.2.3