From 64e16079bb87085fdff5d6268267fd01eacbc5d9 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 21 Nov 2017 21:52:50 +0000 Subject: Cleanup CXFA_ImageData This CL removes the second constructor parameter which is always true and removes all related conditionals. The methods have been changed to const and return instead of using out parameters. Change-Id: Id6d2aa533a212e961e3b8169eef57b7e868d503e Reviewed-on: https://pdfium-review.googlesource.com/19010 Commit-Queue: dsinclair Reviewed-by: Henrique Nakashima --- xfa/fxfa/parser/cxfa_imagedata.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'xfa/fxfa/parser/cxfa_imagedata.h') diff --git a/xfa/fxfa/parser/cxfa_imagedata.h b/xfa/fxfa/parser/cxfa_imagedata.h index b8e5141cd7..445d3d4fba 100644 --- a/xfa/fxfa/parser/cxfa_imagedata.h +++ b/xfa/fxfa/parser/cxfa_imagedata.h @@ -15,22 +15,19 @@ class CXFA_Node; class CXFA_ImageData : public CXFA_DataData { public: - CXFA_ImageData(CXFA_Node* pNode, bool bDefValue); + explicit CXFA_ImageData(CXFA_Node* pNode); - int32_t GetAspect(); - bool GetContent(WideString& wsText); + XFA_ATTRIBUTEENUM GetAspect() const; + WideString GetContent() const; - bool GetHref(WideString& wsHref); + WideString GetHref() const; void SetHref(const WideString& wsHref); - XFA_ATTRIBUTEENUM GetTransferEncoding(); + XFA_ATTRIBUTEENUM GetTransferEncoding() const; void SetTransferEncoding(XFA_ATTRIBUTEENUM iTransferEncoding); - bool GetContentType(WideString& wsContentType); + WideString GetContentType() const; void SetContentType(const WideString& wsContentType); - - private: - bool m_bDefValue; }; #endif // XFA_FXFA_PARSER_CXFA_IMAGEDATA_H_ -- cgit v1.2.3