From eda1761e6a90058a97cee1bcd763a2447eb6a67b Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 2 Nov 2017 19:40:58 +0000 Subject: Remove default values from Set{UserData|Object} and GetUserData. This CL removes the default values and inlines at the call sites. Change-Id: I47ff04a01c30af89949e9c8dd5d51f7ffaef1f98 Reviewed-on: https://pdfium-review.googlesource.com/17610 Commit-Queue: dsinclair Reviewed-by: Tom Sepez --- xfa/fxfa/parser/cxfa_node.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'xfa/fxfa/parser/cxfa_node.cpp') diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp index 1d0b639004..b2677573f5 100644 --- a/xfa/fxfa/parser/cxfa_node.cpp +++ b/xfa/fxfa/parser/cxfa_node.cpp @@ -211,7 +211,7 @@ CXFA_Node* CXFA_Node::Clone(bool bRecursive) { } } pClone->SetFlag(XFA_NodeFlag_Initialized, true); - pClone->JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr); + pClone->JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr, nullptr); return pClone; } @@ -405,7 +405,7 @@ int32_t CXFA_Node::AddBindItem(CXFA_Node* pFormNode) { CXFA_Node* pOldFormItem = static_cast(JSNode()->GetObject(XFA_ATTRIBUTE_BindingNode)); if (!pOldFormItem) { - JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, pFormNode); + JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, pFormNode, nullptr); return 1; } if (pOldFormItem == pFormNode) @@ -430,8 +430,8 @@ int32_t CXFA_Node::RemoveBindItem(CXFA_Node* pFormNode) { *iter = pItems->back(); pItems->pop_back(); if (pItems->size() == 1) { - JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, - (*pItems)[0]); // Invalidates pItems. + JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, (*pItems)[0], + nullptr); // Invalidates pItems. m_uNodeFlags &= ~XFA_NodeFlag_BindFormItems; return 1; } @@ -443,7 +443,7 @@ int32_t CXFA_Node::RemoveBindItem(CXFA_Node* pFormNode) { if (pOldFormItem != pFormNode) return pOldFormItem ? 1 : 0; - JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr); + JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr, nullptr); return 0; } @@ -1936,7 +1936,7 @@ void CXFA_Node::RemoveItem(CXFA_Node* pRemoveInstance, pDataParent->RemoveChild(pDataNode); } } - pFormNode->JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr); + pFormNode->JSNode()->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr, nullptr); } } -- cgit v1.2.3