From 5e35931f90d83e471e4d215034abb4dcb92fac3a Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Sat, 4 Nov 2017 03:32:08 +0000 Subject: Remove default values from CXFA_Node::GetNodeList This CL removes the default values and inlines in the call sites. Change-Id: Iae95653a5d724918c5944f860a0743053e98fe88 Reviewed-on: https://pdfium-review.googlesource.com/17615 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- xfa/fxfa/parser/cxfa_nodehelper.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'xfa/fxfa/parser/cxfa_nodehelper.cpp') diff --git a/xfa/fxfa/parser/cxfa_nodehelper.cpp b/xfa/fxfa/parser/cxfa_nodehelper.cpp index 84237485b3..4c9e67b96c 100644 --- a/xfa/fxfa/parser/cxfa_nodehelper.cpp +++ b/xfa/fxfa/parser/cxfa_nodehelper.cpp @@ -69,7 +69,8 @@ int32_t CXFA_NodeHelper::NodeAcc_TraverseAnySiblings( return 0; int32_t nCount = 0; - for (CXFA_Node* child : parent->GetNodeList(XFA_NODEFILTER_Properties)) { + for (CXFA_Node* child : + parent->GetNodeList(XFA_NODEFILTER_Properties, XFA_Element::Unknown)) { if (bIsClassName) { if (child->GetClassHashCode() == dNameHash) { pSiblings->push_back(child); @@ -87,7 +88,8 @@ int32_t CXFA_NodeHelper::NodeAcc_TraverseAnySiblings( nCount += NodeAcc_TraverseAnySiblings(child, dNameHash, pSiblings, bIsClassName); } - for (CXFA_Node* child : parent->GetNodeList(XFA_NODEFILTER_Children)) { + for (CXFA_Node* child : + parent->GetNodeList(XFA_NODEFILTER_Children, XFA_Element::Unknown)) { if (bIsClassName) { if (child->GetClassHashCode() == dNameHash) { pSiblings->push_back(child); @@ -120,7 +122,8 @@ int32_t CXFA_NodeHelper::NodeAcc_TraverseSiblings( int32_t nCount = 0; if (bIsFindProperty) { - for (CXFA_Node* child : parent->GetNodeList(XFA_NODEFILTER_Properties)) { + for (CXFA_Node* child : + parent->GetNodeList(XFA_NODEFILTER_Properties, XFA_Element::Unknown)) { if (bIsClassName) { if (child->GetClassHashCode() == dNameHash) { pSiblings->push_back(child); @@ -145,7 +148,8 @@ int32_t CXFA_NodeHelper::NodeAcc_TraverseSiblings( if (nCount > 0) return nCount; } - for (CXFA_Node* child : parent->GetNodeList(XFA_NODEFILTER_Children)) { + for (CXFA_Node* child : + parent->GetNodeList(XFA_NODEFILTER_Children, XFA_Element::Unknown)) { if (child->GetElementType() == XFA_Element::Variables) continue; -- cgit v1.2.3