From 9a3a7709103a872037dcea1f3cf0b7785a3da191 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Mon, 23 Apr 2018 18:14:16 +0000 Subject: Change CFX_XML Save to take a write stream This CL changes CFX_XML to use an IFX_SeekableWriteStream instead of the more generic IFX_SeekableStream. Change-Id: I6e4def380c43eca755d91ad5cb6146c2dfdaee10 Reviewed-on: https://pdfium-review.googlesource.com/30877 Commit-Queue: dsinclair Reviewed-by: Tom Sepez --- xfa/fxfa/parser/cxfa_xmllocale.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'xfa/fxfa/parser/cxfa_xmllocale.cpp') diff --git a/xfa/fxfa/parser/cxfa_xmllocale.cpp b/xfa/fxfa/parser/cxfa_xmllocale.cpp index ffb4cd9dde..cbee75725a 100644 --- a/xfa/fxfa/parser/cxfa_xmllocale.cpp +++ b/xfa/fxfa/parser/cxfa_xmllocale.cpp @@ -38,11 +38,10 @@ std::unique_ptr CXFA_XMLLocale::Create( return nullptr; CFX_XMLElement* locale = nullptr; - for (auto* child = root->GetFirstChild(); child; - child = child->GetNextSibling()) { + for (const auto& child : *(root.get())) { if (child->GetType() != FX_XMLNODE_Element) continue; - CFX_XMLElement* elem = static_cast(child); + CFX_XMLElement* elem = static_cast(child.get()); if (elem->GetName() == L"locale") { locale = elem; break; @@ -126,12 +125,11 @@ WideString CXFA_XMLLocale::GetCalendarSymbol(const WideStringView& symbol, WideString pstrSymbolNames = symbol + L"Names"; CFX_XMLElement* name_child = nullptr; - for (auto* name = child->GetFirstChild(); name; - name = name->GetNextSibling()) { + for (const auto& name : *child) { if (name->GetType() != FX_XMLNODE_Element) continue; - auto* elem = static_cast(name); + auto* elem = static_cast(name.get()); if (elem->GetName() != pstrSymbolNames) continue; @@ -210,12 +208,11 @@ WideString CXFA_XMLLocale::GetNumPattern(FX_LOCALENUMSUBCATEGORY eType) const { WideString CXFA_XMLLocale::GetPattern(CFX_XMLElement* patterns, const WideStringView& bsTag, const WideStringView& wsName) const { - for (auto* child = patterns->GetFirstChild(); child; - child = child->GetNextSibling()) { + for (const auto& child : *patterns) { if (child->GetType() != FX_XMLNODE_Element) continue; - CFX_XMLElement* pattern = static_cast(child); + CFX_XMLElement* pattern = static_cast(child.get()); if (pattern->GetName() != bsTag) continue; if (pattern->GetAttribute(L"name") != wsName) -- cgit v1.2.3