From 8f3074bef53ed941daef3f32981b1449db7bcc26 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 2 Jun 2016 17:45:25 -0700 Subject: Remove FXJSE_Value_ToObject and call methods directly This Cl removes the global FXJSE_Value_ToObject method and adds individual methods on CXFA_Value to do the needed conversions. Review-Url: https://codereview.chromium.org/2026993003 --- xfa/fxfa/parser/xfa_script.h | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) (limited to 'xfa/fxfa/parser/xfa_script.h') diff --git a/xfa/fxfa/parser/xfa_script.h b/xfa/fxfa/parser/xfa_script.h index da348f7a36..e81a7b9754 100644 --- a/xfa/fxfa/parser/xfa_script.h +++ b/xfa/fxfa/parser/xfa_script.h @@ -8,6 +8,7 @@ #define XFA_FXFA_PARSER_XFA_SCRIPT_H_ #include "xfa/fxfa/include/fxfa.h" +#include "xfa/fxfa/parser/cxfa_valuearray.h" #include "xfa/fxjse/value.h" #define XFA_RESOLVENODE_Children 0x0001 @@ -36,26 +37,6 @@ enum XFA_RESOVENODE_RSTYPE { XFA_RESOVENODE_RSTYPE_ExistNodes, }; -class CXFA_ValueArray : public CFX_ArrayTemplate { - public: - CXFA_ValueArray(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {} - - ~CXFA_ValueArray() { - for (int32_t i = 0; i < GetSize(); i++) { - delete GetAt(i); - } - } - - void GetAttributeObject(CXFA_ObjArray& objArray) { - for (int32_t i = 0; i < GetSize(); i++) { - objArray.Add( - static_cast(FXJSE_Value_ToObject(GetAt(i), nullptr))); - } - } - - v8::Isolate* m_pIsolate; -}; - struct XFA_RESOLVENODE_RS { XFA_RESOLVENODE_RS() : dwFlags(XFA_RESOVENODE_RSTYPE_Nodes), pScriptAttribute(NULL) {} -- cgit v1.2.3