From 738b08ce6b9f80d93b815411b47c2b11c2f090f6 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 1 Mar 2016 14:45:20 -0500 Subject: Fix and enable lint checks. This CL fixes and enables: * readability/namespace * readability/multiline_string * readability/multiline_comment * readability/inheritance * readability/function * readability/braces R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1747123002 . --- xfa/src/fdp/src/css/fde_cssdatatable.h | 2 +- xfa/src/fdp/src/css/fde_cssdeclaration.cpp | 3 ++- xfa/src/fdp/src/fde/fde_object.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) (limited to 'xfa/src/fdp') diff --git a/xfa/src/fdp/src/css/fde_cssdatatable.h b/xfa/src/fdp/src/css/fde_cssdatatable.h index df396228fc..2502ed7fe5 100644 --- a/xfa/src/fdp/src/css/fde_cssdatatable.h +++ b/xfa/src/fdp/src/css/fde_cssdatatable.h @@ -21,7 +21,7 @@ class CFDE_CSSFunction : public CFX_Target { IFDE_CSSValue* GetArgs(int32_t index) const { return m_pArgList->GetValue(index); } - const FX_WCHAR* GetFuncName() const { return m_pszFuncName; }; + const FX_WCHAR* GetFuncName() const { return m_pszFuncName; } protected: IFDE_CSSValueList* m_pArgList; diff --git a/xfa/src/fdp/src/css/fde_cssdeclaration.cpp b/xfa/src/fdp/src/css/fde_cssdeclaration.cpp index 4eea30c150..73d0921b15 100644 --- a/xfa/src/fdp/src/css/fde_cssdeclaration.cpp +++ b/xfa/src/fdp/src/css/fde_cssdeclaration.cpp @@ -932,11 +932,12 @@ FX_BOOL CFDE_CSSDeclaration::ParseBackgroundProperty( } const FDE_CSSCOLORTABLE* pColorItem = FDE_GetCSSColorByName(pszValue, iValueLen); - if (pColorItem != NULL) + if (pColorItem != NULL) { if (pColor == NULL) { pColor = FXTARGET_NewWith(pStaticStore) CFDE_CSSPrimitiveValue(pColorItem->dwValue); } + } } break; case FDE_CSSPRIMITIVETYPE_RGB: if (pColor == NULL) { diff --git a/xfa/src/fdp/src/fde/fde_object.h b/xfa/src/fdp/src/fde/fde_object.h index 222968c357..4e90ed2aa6 100644 --- a/xfa/src/fdp/src/fde/fde_object.h +++ b/xfa/src/fdp/src/fde/fde_object.h @@ -143,7 +143,7 @@ class CFDE_HatchBrush : public IFDE_HatchBrush, public CFX_Target { } } - virtual int32_t GetHatchStyle() const { return m_iStyle; }; + virtual int32_t GetHatchStyle() const { return m_iStyle; } virtual FX_BOOL SetHatchStyle(int32_t iHatchStyle) { m_iStyle = iHatchStyle; return m_iStyle >= FDE_HATCHSTYLE_Min && m_iStyle <= FDE_HATCHSTYLE_Max; -- cgit v1.2.3