From 5570d23890cc7bae4903a29fbcf8ac543ba1a2c7 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 5 Nov 2015 08:46:13 -0800 Subject: Fix XFA compilation warnings, part 2 Mostly unused variables, unused private members, or initialization order. Added a few missing initializers for pointer members along the way. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1414903004 . --- xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'xfa/src/fxbarcode/oned') diff --git a/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp b/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp index 43bd696379..99484493f3 100644 --- a/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp +++ b/xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp @@ -37,15 +37,14 @@ const int32_t CBC_OnedCode39Reader::CHARACTER_ENCODINGS[44] = { 0x085, 0x184, 0x0C4, 0x094, 0x0A8, 0x0A2, 0x08A, 0x02A}; const int32_t CBC_OnedCode39Reader::ASTERISK_ENCODING = 0x094; CBC_OnedCode39Reader::CBC_OnedCode39Reader() - : m_extendedMode(FALSE), m_usingCheckDigit(FALSE) {} -CBC_OnedCode39Reader::CBC_OnedCode39Reader(FX_BOOL usingCheckDigit) { - m_usingCheckDigit = usingCheckDigit; - m_extendedMode = FALSE; + : m_usingCheckDigit(FALSE), m_extendedMode(FALSE) { +} +CBC_OnedCode39Reader::CBC_OnedCode39Reader(FX_BOOL usingCheckDigit) + : m_usingCheckDigit(usingCheckDigit), m_extendedMode(FALSE) { } CBC_OnedCode39Reader::CBC_OnedCode39Reader(FX_BOOL usingCheckDigit, - FX_BOOL extendedMode) { - m_extendedMode = extendedMode; - m_usingCheckDigit = usingCheckDigit; + FX_BOOL extendedMode) + : m_usingCheckDigit(usingCheckDigit), m_extendedMode(extendedMode) { } CBC_OnedCode39Reader::~CBC_OnedCode39Reader() {} CFX_ByteString CBC_OnedCode39Reader::DecodeRow(int32_t rowNumber, -- cgit v1.2.3