From bbd41bbd5e4ae9ca4f4a800c955471e41a947d98 Mon Sep 17 00:00:00 2001 From: Bruce Dawson Date: Mon, 5 Jan 2015 11:45:45 -0800 Subject: Fix one remaining misuse of FX_WSTRC on FX_WCHAR* vars. FX_WSTRC is only valid on arrays, not pointers. In this code it was being passed a pointer to a URL. This was found when integrating a change to FX_WSTRC that disallows pointer arguments. The consequence of this bug is that the URL will end up with incorrect lengths. It will be one character long in 32-bit builds, and three characters long in 64-bit builds (sizeof(WCHAR*)-1). R=bo_xu@foxitsoftware.com Review URL: https://codereview.chromium.org/831293002 --- xfa/src/fxfa/src/app/xfa_fftext.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xfa/src/fxfa') diff --git a/xfa/src/fxfa/src/app/xfa_fftext.cpp b/xfa/src/fxfa/src/app/xfa_fftext.cpp index 8b90a180cd..eed50b50ca 100644 --- a/xfa/src/fxfa/src/app/xfa_fftext.cpp +++ b/xfa/src/fxfa/src/app/xfa_fftext.cpp @@ -141,7 +141,7 @@ FX_BOOL CXFA_FFText::OnLButtonUp(FX_DWORD dwFlags, FX_FLOAT fx, FX_FLOAT fy) return FALSE; } CXFA_FFDoc* pDoc = GetDoc(); - pDoc->GetDocProvider()->GotoURL((XFA_HDOC)pDoc, FX_WSTRC(wsURLContent), FALSE); + pDoc->GetDocProvider()->GotoURL((XFA_HDOC)pDoc, CFX_WideStringC(wsURLContent), FALSE); return TRUE; } FX_DWORD CXFA_FFText::OnHitTest(FX_FLOAT fx, FX_FLOAT fy) -- cgit v1.2.3