From 39cf6a765ae349242289ec3287eaf4d6c5fd57f8 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 4 Oct 2018 23:33:30 +0000 Subject: Change |virtual ~Foo(){}| to |virtual ~Foo()=default;| Otherwise code coverage flags the empty body as unreachable. Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767 Reviewed-on: https://pdfium-review.googlesource.com/c/43514 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- xfa/fwl/ifwl_adaptertimermgr.h | 2 +- xfa/fwl/ifwl_themeprovider.h | 2 +- xfa/fwl/ifwl_widgetdelegate.h | 2 +- xfa/fxfa/fm2js/cxfa_fmexpression.h | 2 +- xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h | 2 +- xfa/fxfa/fxfa.h | 6 +++--- 6 files changed, 8 insertions(+), 8 deletions(-) (limited to 'xfa') diff --git a/xfa/fwl/ifwl_adaptertimermgr.h b/xfa/fwl/ifwl_adaptertimermgr.h index 23627d9191..9f9e5ca91d 100644 --- a/xfa/fwl/ifwl_adaptertimermgr.h +++ b/xfa/fwl/ifwl_adaptertimermgr.h @@ -11,7 +11,7 @@ class IFWL_AdapterTimerMgr { public: - virtual ~IFWL_AdapterTimerMgr() {} + virtual ~IFWL_AdapterTimerMgr() = default; virtual void Start(CFWL_Timer* pTimer, uint32_t dwElapse, bool bImmediately, diff --git a/xfa/fwl/ifwl_themeprovider.h b/xfa/fwl/ifwl_themeprovider.h index 78c3e19fe2..19967680f8 100644 --- a/xfa/fwl/ifwl_themeprovider.h +++ b/xfa/fwl/ifwl_themeprovider.h @@ -19,7 +19,7 @@ class CFWL_Widget; class IFWL_ThemeProvider { public: - virtual ~IFWL_ThemeProvider() {} + virtual ~IFWL_ThemeProvider() = default; virtual void DrawBackground(CFWL_ThemeBackground* pParams) = 0; virtual void DrawText(CFWL_ThemeText* pParams) = 0; diff --git a/xfa/fwl/ifwl_widgetdelegate.h b/xfa/fwl/ifwl_widgetdelegate.h index 09bac9ab4e..17b8933974 100644 --- a/xfa/fwl/ifwl_widgetdelegate.h +++ b/xfa/fwl/ifwl_widgetdelegate.h @@ -16,7 +16,7 @@ class CFX_Matrix; class IFWL_WidgetDelegate { public: - virtual ~IFWL_WidgetDelegate() {} + virtual ~IFWL_WidgetDelegate() = default; virtual void OnProcessMessage(CFWL_Message* pMessage) = 0; virtual void OnProcessEvent(CFWL_Event* pEvent) = 0; diff --git a/xfa/fxfa/fm2js/cxfa_fmexpression.h b/xfa/fxfa/fm2js/cxfa_fmexpression.h index c20d76b075..37999a17b3 100644 --- a/xfa/fxfa/fm2js/cxfa_fmexpression.h +++ b/xfa/fxfa/fm2js/cxfa_fmexpression.h @@ -16,7 +16,7 @@ class CFX_WideTextBuf; class CXFA_FMExpression { public: - virtual ~CXFA_FMExpression() {} + virtual ~CXFA_FMExpression() = default; virtual bool ToJavaScript(CFX_WideTextBuf* js, ReturnType type) = 0; protected: diff --git a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h index 275d7d4fcb..ae8f38e6e6 100644 --- a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h +++ b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h @@ -25,7 +25,7 @@ class CFX_WideTextBuf; class CXFA_FMSimpleExpression { public: - virtual ~CXFA_FMSimpleExpression() {} + virtual ~CXFA_FMSimpleExpression() = default; virtual bool ToJavaScript(CFX_WideTextBuf* js, ReturnType type) = 0; XFA_FM_TOKEN GetOperatorToken() const; diff --git a/xfa/fxfa/fxfa.h b/xfa/fxfa/fxfa.h index 5b51067c40..0796347506 100644 --- a/xfa/fxfa/fxfa.h +++ b/xfa/fxfa/fxfa.h @@ -118,7 +118,7 @@ enum XFA_WIDGETTYPE { // Probably should be called IXFA_AppDelegate. class IXFA_AppProvider { public: - virtual ~IXFA_AppProvider() {} + virtual ~IXFA_AppProvider() = default; /** * Returns the language of the running host application. Such as zh_CN @@ -221,7 +221,7 @@ class IXFA_AppProvider { class IXFA_DocEnvironment { public: - virtual ~IXFA_DocEnvironment() {} + virtual ~IXFA_DocEnvironment() = default; virtual void SetChangeMark(CXFA_FFDoc* hDoc) = 0; virtual void InvalidateRect(CXFA_FFPageView* pPageView, @@ -277,7 +277,7 @@ class IXFA_DocEnvironment { class IXFA_WidgetIterator { public: - virtual ~IXFA_WidgetIterator() {} + virtual ~IXFA_WidgetIterator() = default; virtual void Reset() = 0; virtual CXFA_FFWidget* MoveToFirst() = 0; -- cgit v1.2.3