From a99de0ec3cda8ff5b0d6383a059dd39c8626e504 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Mon, 27 Feb 2017 14:45:56 -0800 Subject: Clean up CXML_Element. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Set more members in the ctor - Remove dead code - Use more unique_ptrs Change-Id: Idfe85d07c784a57862f9314bc85f407f817b8f2f Reviewed-on: https://pdfium-review.googlesource.com/2844 Commit-Queue: Lei Zhang Reviewed-by: Nicolás Peña Reviewed-by: dsinclair --- xfa/fxfa/parser/xfa_localemgr.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xfa') diff --git a/xfa/fxfa/parser/xfa_localemgr.cpp b/xfa/fxfa/parser/xfa_localemgr.cpp index cfa5801e3c..0cd64ea6dc 100644 --- a/xfa/fxfa/parser/xfa_localemgr.cpp +++ b/xfa/fxfa/parser/xfa_localemgr.cpp @@ -1053,7 +1053,7 @@ static std::unique_ptr XFA_GetLocaleFromBuffer(const uint8_t* pBuf, pCodecMgr->GetFlateModule()->FlateOrLZWDecode(false, pBuf, nBufLen, true, 0, 0, 0, 0, 0, pOut, dwSize); if (pOut) { - pLocale.reset(CXML_Element::Parse(pOut, dwSize)); + pLocale = CXML_Element::Parse(pOut, dwSize); FX_Free(pOut); } return pLocale ? std::unique_ptr( -- cgit v1.2.3