From ba692bf3ab3df5d0b83fb30f9e25953bed41ed5c Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 30 Oct 2015 13:11:31 -0700 Subject: XFA: Remove null CFX_DIBAttribute default argument. Add some consts and overrides along the way. Group some statics together. Tidy some unused vars. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1411683005 . --- xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'xfa') diff --git a/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp b/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp index e626c4021c..01c4f6c1fd 100644 --- a/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp +++ b/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp @@ -34,7 +34,7 @@ static CFX_DIBitmap* CreateDIBSource(IFX_FileRead* fileread) { pCodecMgr = new CCodec_ModuleMgr(); pImageCodec = pCodecMgr->CreateProgressiveDecoder(); FXCODEC_STATUS status = FXCODEC_STATUS_DECODE_FINISH; - status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN); + status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN, nullptr); if (status != FXCODEC_STATUS_FRAME_READY) { return NULL; } @@ -181,11 +181,7 @@ CBC_LuminanceSource* CBC_BufferedImageLuminanceSource::Crop(int32_t left, } CBC_LuminanceSource* CBC_BufferedImageLuminanceSource::RotateCounterClockwise( int32_t& e) { - if (!IsRotateSupported()) { + if (!IsRotateSupported()) e = BCExceptionRotateNotSupported; - return NULL; - } - int32_t sourceWidth = m_width; - int32_t sourceHeight = m_height; return NULL; } -- cgit v1.2.3