From ebe865db548f768038186054fc0f1eb024565c43 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 21 Nov 2017 22:05:40 +0000 Subject: Cleanup CXFA_SubmitData This CL cleans up the CXFA_SubmitData methods by using returns instead of out-params, sets the correct return types and makes the methods const. Change-Id: I41fe8f59e450ca444b64c291ac4a0a199c7ad0cf Reviewed-on: https://pdfium-review.googlesource.com/19111 Reviewed-by: Henrique Nakashima Commit-Queue: dsinclair --- xfa/fxfa/parser/cxfa_submitdata.cpp | 12 ++++++------ xfa/fxfa/parser/cxfa_submitdata.h | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) (limited to 'xfa') diff --git a/xfa/fxfa/parser/cxfa_submitdata.cpp b/xfa/fxfa/parser/cxfa_submitdata.cpp index c461ed2a09..e10dec62f0 100644 --- a/xfa/fxfa/parser/cxfa_submitdata.cpp +++ b/xfa/fxfa/parser/cxfa_submitdata.cpp @@ -10,18 +10,18 @@ CXFA_SubmitData::CXFA_SubmitData(CXFA_Node* pNode) : CXFA_DataData(pNode) {} -bool CXFA_SubmitData::IsSubmitEmbedPDF() { +bool CXFA_SubmitData::IsSubmitEmbedPDF() const { return m_pNode->JSNode()->GetBoolean(XFA_Attribute::EmbedPDF); } -int32_t CXFA_SubmitData::GetSubmitFormat() { +XFA_ATTRIBUTEENUM CXFA_SubmitData::GetSubmitFormat() const { return m_pNode->JSNode()->GetEnum(XFA_Attribute::Format); } -void CXFA_SubmitData::GetSubmitTarget(WideString& wsTarget) { - wsTarget = m_pNode->JSNode()->GetCData(XFA_Attribute::Target); +WideString CXFA_SubmitData::GetSubmitTarget() const { + return m_pNode->JSNode()->GetCData(XFA_Attribute::Target); } -void CXFA_SubmitData::GetSubmitXDPContent(WideString& wsContent) { - wsContent = m_pNode->JSNode()->GetCData(XFA_Attribute::XdpContent); +WideString CXFA_SubmitData::GetSubmitXDPContent() const { + return m_pNode->JSNode()->GetCData(XFA_Attribute::XdpContent); } diff --git a/xfa/fxfa/parser/cxfa_submitdata.h b/xfa/fxfa/parser/cxfa_submitdata.h index e90848d9f1..039c327b97 100644 --- a/xfa/fxfa/parser/cxfa_submitdata.h +++ b/xfa/fxfa/parser/cxfa_submitdata.h @@ -17,10 +17,10 @@ class CXFA_SubmitData : public CXFA_DataData { public: explicit CXFA_SubmitData(CXFA_Node* pNode); - bool IsSubmitEmbedPDF(); - int32_t GetSubmitFormat(); - void GetSubmitTarget(WideString& wsTarget); - void GetSubmitXDPContent(WideString& wsContent); + bool IsSubmitEmbedPDF() const; + XFA_ATTRIBUTEENUM GetSubmitFormat() const; + WideString GetSubmitTarget() const; + WideString GetSubmitXDPContent() const; }; #endif // XFA_FXFA_PARSER_CXFA_SUBMITDATA_H_ -- cgit v1.2.3