1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
|
// Copyright 2017 PDFium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "core/fpdfapi/parser/cpdf_read_validator.h"
#include <limits>
#include <utility>
#include <vector>
#include "core/fxcrt/cfx_memorystream.h"
#include "core/fxcrt/fx_stream.h"
#include "testing/fx_string_testhelpers.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
constexpr uint32_t kTestDataSize = 64 * 1024 - 467;
std::pair<FX_FILESIZE, FX_FILESIZE> MakeRange(uint32_t start, uint32_t end) {
return std::pair<FX_FILESIZE, FX_FILESIZE>(start, end);
}
class MockFileAvail : public CPDF_DataAvail::FileAvail {
public:
MockFileAvail() : available_range_(0, 0) {}
~MockFileAvail() override {}
bool IsDataAvail(FX_FILESIZE offset, size_t size) override {
return available_range_.first <= offset &&
available_range_.second >= static_cast<FX_FILESIZE>(offset + size);
}
void SetAvailableRange(const std::pair<FX_FILESIZE, FX_FILESIZE>& range) {
available_range_ = range;
}
void SetAvailableRange(uint32_t start, uint32_t end) {
SetAvailableRange(MakeRange(start, end));
}
private:
std::pair<FX_FILESIZE, FX_FILESIZE> available_range_;
};
class MockDownloadHints : public CPDF_DataAvail::DownloadHints {
public:
MockDownloadHints() : last_requested_range_(0, 0) {}
~MockDownloadHints() override {}
void AddSegment(FX_FILESIZE offset, size_t size) override {
last_requested_range_.first = offset;
last_requested_range_.second = offset + size;
}
const std::pair<FX_FILESIZE, FX_FILESIZE>& GetLastRequstedRange() const {
return last_requested_range_;
}
void Reset() { last_requested_range_ = MakeRange(0, 0); }
private:
std::pair<FX_FILESIZE, FX_FILESIZE> last_requested_range_;
};
} // namespace
TEST(CPDF_ReadValidatorTest, UnavailableData) {
std::vector<uint8_t> test_data(kTestDataSize);
auto file = pdfium::MakeRetain<CFX_MemoryStream>(test_data.data(),
test_data.size(), false);
MockFileAvail file_avail;
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, &file_avail);
std::vector<uint8_t> read_buffer(100);
EXPECT_FALSE(
validator->ReadBlock(read_buffer.data(), 5000, read_buffer.size()));
EXPECT_FALSE(validator->read_error());
EXPECT_TRUE(validator->has_unavailable_data());
validator->ResetErrors();
file_avail.SetAvailableRange(5000, 5000 + read_buffer.size());
EXPECT_TRUE(
validator->ReadBlock(read_buffer.data(), 5000, read_buffer.size()));
EXPECT_FALSE(validator->read_error());
EXPECT_FALSE(validator->has_unavailable_data());
}
TEST(CPDF_ReadValidatorTest, UnavailableDataWithHints) {
std::vector<uint8_t> test_data(kTestDataSize);
auto file = pdfium::MakeRetain<CFX_MemoryStream>(test_data.data(),
test_data.size(), false);
MockFileAvail file_avail;
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, &file_avail);
MockDownloadHints hints;
validator->SetDownloadHints(&hints);
std::vector<uint8_t> read_buffer(100);
EXPECT_FALSE(
validator->ReadBlock(read_buffer.data(), 5000, read_buffer.size()));
EXPECT_FALSE(validator->read_error());
EXPECT_TRUE(validator->has_unavailable_data());
// Requested range should be enlarged and aligned.
EXPECT_EQ(MakeRange(4608, 5120), hints.GetLastRequstedRange());
file_avail.SetAvailableRange(hints.GetLastRequstedRange());
hints.Reset();
validator->ResetErrors();
EXPECT_TRUE(
validator->ReadBlock(read_buffer.data(), 5000, read_buffer.size()));
// No new request on already available data.
EXPECT_EQ(MakeRange(0, 0), hints.GetLastRequstedRange());
EXPECT_FALSE(validator->read_error());
EXPECT_FALSE(validator->has_unavailable_data());
validator->ResetErrors();
// Try read unavailable data at file end.
EXPECT_FALSE(validator->ReadBlock(read_buffer.data(),
validator->GetSize() - read_buffer.size(),
read_buffer.size()));
// Should not enlarge request at file end.
EXPECT_EQ(validator->GetSize(), hints.GetLastRequstedRange().second);
EXPECT_FALSE(validator->read_error());
EXPECT_TRUE(validator->has_unavailable_data());
validator->SetDownloadHints(nullptr);
}
TEST(CPDF_ReadValidatorTest, ReadError) {
auto file = pdfium::MakeRetain<CFX_InvalidSeekableReadStream>(kTestDataSize);
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, nullptr);
static const uint32_t kBufferSize = 3 * 1000;
std::vector<uint8_t> buffer(kBufferSize);
EXPECT_FALSE(validator->ReadBlock(buffer.data(), 5000, 100));
EXPECT_TRUE(validator->read_error());
EXPECT_TRUE(validator->has_unavailable_data());
}
TEST(CPDF_ReadValidatorTest, IntOverflow) {
std::vector<uint8_t> test_data(kTestDataSize);
auto file = pdfium::MakeRetain<CFX_MemoryStream>(test_data.data(),
test_data.size(), false);
MockFileAvail file_avail;
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, &file_avail);
std::vector<uint8_t> read_buffer(100);
// If we have int overflow, this is equal reading after file end. This is not
// read_error, and in this case we have not unavailable data. It is just error
// of input params.
EXPECT_FALSE(validator->ReadBlock(read_buffer.data(),
std::numeric_limits<FX_FILESIZE>::max() - 1,
read_buffer.size()));
EXPECT_FALSE(validator->read_error());
EXPECT_FALSE(validator->has_unavailable_data());
}
TEST(CPDF_ReadValidatorTest, Session) {
std::vector<uint8_t> test_data(kTestDataSize);
auto file = pdfium::MakeRetain<CFX_InvalidSeekableReadStream>(kTestDataSize);
MockFileAvail file_avail;
MockDownloadHints hints;
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, &file_avail);
validator->SetDownloadHints(&hints);
const CPDF_ReadValidator::Session read_session(validator.Get());
ASSERT_FALSE(validator->has_read_problems());
// Data is unavailable
validator->ReadBlock(test_data.data(), 0, 100);
EXPECT_TRUE(validator->has_read_problems());
EXPECT_TRUE(validator->has_unavailable_data());
EXPECT_FALSE(validator->read_error());
{
const CPDF_ReadValidator::Session read_subsession(validator.Get());
// The read problems should be hidden.
EXPECT_FALSE(validator->has_read_problems());
file_avail.SetAvailableRange(0, 100);
// Read fail.
validator->ReadBlock(test_data.data(), 0, 100);
EXPECT_TRUE(validator->has_read_problems());
EXPECT_TRUE(validator->has_unavailable_data());
EXPECT_TRUE(validator->read_error());
}
// The problems should be merged
EXPECT_TRUE(validator->has_read_problems());
EXPECT_TRUE(validator->has_unavailable_data());
EXPECT_TRUE(validator->read_error());
}
TEST(CPDF_ReadValidatorTest, SessionReset) {
std::vector<uint8_t> test_data(kTestDataSize);
auto file = pdfium::MakeRetain<CFX_InvalidSeekableReadStream>(kTestDataSize);
MockFileAvail file_avail;
MockDownloadHints hints;
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, &file_avail);
validator->SetDownloadHints(&hints);
const CPDF_ReadValidator::Session read_session(validator.Get());
ASSERT_FALSE(validator->has_read_problems());
// Data is unavailable
validator->ReadBlock(test_data.data(), 0, 100);
EXPECT_TRUE(validator->has_read_problems());
EXPECT_TRUE(validator->has_unavailable_data());
EXPECT_FALSE(validator->read_error());
{
const CPDF_ReadValidator::Session read_subsession(validator.Get());
// The read problems should be hidden.
EXPECT_FALSE(validator->has_read_problems());
file_avail.SetAvailableRange(0, 100);
// Read fail.
validator->ReadBlock(test_data.data(), 0, 100);
EXPECT_TRUE(validator->has_read_problems());
EXPECT_TRUE(validator->has_unavailable_data());
EXPECT_TRUE(validator->read_error());
// Reset session.
validator->ResetErrors();
EXPECT_FALSE(validator->has_read_problems());
}
// The problems should be restored.
EXPECT_TRUE(validator->has_read_problems());
EXPECT_TRUE(validator->has_unavailable_data());
EXPECT_FALSE(validator->read_error());
}
TEST(CPDF_ReadValidatorTest, CheckDataRangeAndRequestIfUnavailable) {
std::vector<uint8_t> test_data(kTestDataSize);
auto file = pdfium::MakeRetain<CFX_MemoryStream>(test_data.data(),
test_data.size(), false);
MockFileAvail file_avail;
auto validator = pdfium::MakeRetain<CPDF_ReadValidator>(file, &file_avail);
MockDownloadHints hints;
validator->SetDownloadHints(&hints);
EXPECT_FALSE(validator->CheckDataRangeAndRequestIfUnavailable(5000, 100));
EXPECT_FALSE(validator->read_error());
EXPECT_TRUE(validator->has_unavailable_data());
// Requested range should be enlarged and aligned.
EXPECT_EQ(MakeRange(4608, 5632), hints.GetLastRequstedRange());
file_avail.SetAvailableRange(hints.GetLastRequstedRange());
hints.Reset();
validator->ResetErrors();
EXPECT_TRUE(validator->CheckDataRangeAndRequestIfUnavailable(5000, 100));
// No new request on already available data.
EXPECT_EQ(MakeRange(0, 0), hints.GetLastRequstedRange());
EXPECT_FALSE(validator->read_error());
EXPECT_FALSE(validator->has_unavailable_data());
std::vector<uint8_t> read_buffer(100);
EXPECT_TRUE(
validator->ReadBlock(read_buffer.data(), 5000, read_buffer.size()));
// No new request on already available data.
EXPECT_EQ(MakeRange(0, 0), hints.GetLastRequstedRange());
EXPECT_FALSE(validator->read_error());
EXPECT_FALSE(validator->has_unavailable_data());
validator->ResetErrors();
// Try request unavailable data at file end.
EXPECT_FALSE(validator->CheckDataRangeAndRequestIfUnavailable(
validator->GetSize() - 100, 100));
// Should not enlarge request at file end.
EXPECT_EQ(validator->GetSize(), hints.GetLastRequstedRange().second);
EXPECT_FALSE(validator->read_error());
EXPECT_TRUE(validator->has_unavailable_data());
validator->SetDownloadHints(nullptr);
}
|
