1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
|
// Copyright 2014 PDFium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stdint.h>
#include <limits>
#include "core/fxcodec/codec/codec_int.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libopenjpeg20/opj_malloc.h"
static const OPJ_OFF_T kSkipError = static_cast<OPJ_OFF_T>(-1);
static const OPJ_SIZE_T kReadError = static_cast<OPJ_SIZE_T>(-1);
static const uint8_t stream_data[] = {
0x00, 0x01, 0x02, 0x03,
0x84, 0x85, 0x86, 0x87, // Include some hi-bytes, too.
};
union Float_t {
Float_t(float num = 0.0f) : f(num) {}
int32_t i;
float f;
};
TEST(fxcodec, CMYK_Rounding) {
// Testing all floats from 0.0 to 1.0 takes about 35 seconds in release
// builds and much longer in debug builds, so just test the known-dangerous
// range.
const float startValue = 0.001f;
const float endValue = 0.003f;
float R = 0.0f, G = 0.0f, B = 0.0f;
// Iterate through floats by incrementing the representation, as discussed in
// https://randomascii.wordpress.com/2012/01/23/stupid-float-tricks-2/
for (Float_t f = startValue; f.f < endValue; f.i++) {
std::tie(R, G, B) = AdobeCMYK_to_sRGB(f.f, f.f, f.f, f.f);
}
// Check various other 'special' numbers.
std::tie(R, G, B) = AdobeCMYK_to_sRGB(0.0f, 0.25f, 0.5f, 1.0f);
}
TEST(fxcodec, DecodeDataNullDecodeData) {
uint8_t buffer[16];
DecodeData* ptr = nullptr;
// Error codes, not segvs, should callers pass us a nullptr pointer.
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), ptr));
EXPECT_EQ(kSkipError, opj_skip_from_memory(1, ptr));
EXPECT_FALSE(opj_seek_from_memory(1, ptr));
}
TEST(fxcodec, DecodeDataNullStream) {
DecodeData dd(nullptr, 0);
uint8_t buffer[16];
// Reads of size 0 do nothing but return an error code.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Reads of nonzero size do nothing but return an error code.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Skips of size 0 always return an error code.
EXPECT_EQ(kSkipError, opj_skip_from_memory(0, &dd));
// Skips of nonzero size always return an error code.
EXPECT_EQ(kSkipError, opj_skip_from_memory(1, &dd));
// Seeks to 0 offset return in error.
EXPECT_FALSE(opj_seek_from_memory(0, &dd));
// Seeks to non-zero offsets return in error.
EXPECT_FALSE(opj_seek_from_memory(1, &dd));
}
TEST(fxcodec, DecodeDataZeroSize) {
DecodeData dd(stream_data, 0);
uint8_t buffer[16];
// Reads of size 0 do nothing but return an error code.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Reads of nonzero size do nothing but return an error code.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Skips of size 0 always return an error code.
EXPECT_EQ(kSkipError, opj_skip_from_memory(0, &dd));
// Skips of nonzero size always return an error code.
EXPECT_EQ(kSkipError, opj_skip_from_memory(1, &dd));
// Seeks to 0 offset return in error.
EXPECT_FALSE(opj_seek_from_memory(0, &dd));
// Seeks to non-zero offsets return in error.
EXPECT_FALSE(opj_seek_from_memory(1, &dd));
}
TEST(fxcodec, DecodeDataReadInBounds) {
uint8_t buffer[16];
{
DecodeData dd(stream_data, sizeof(stream_data));
// Exact sized read in a single call.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(8u, opj_read_from_memory(buffer, sizeof(buffer), &dd));
EXPECT_EQ(0x00, buffer[0]);
EXPECT_EQ(0x01, buffer[1]);
EXPECT_EQ(0x02, buffer[2]);
EXPECT_EQ(0x03, buffer[3]);
EXPECT_EQ(0x84, buffer[4]);
EXPECT_EQ(0x85, buffer[5]);
EXPECT_EQ(0x86, buffer[6]);
EXPECT_EQ(0x87, buffer[7]);
EXPECT_EQ(0xbd, buffer[8]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Simple read.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(2u, opj_read_from_memory(buffer, 2, &dd));
EXPECT_EQ(0x00, buffer[0]);
EXPECT_EQ(0x01, buffer[1]);
EXPECT_EQ(0xbd, buffer[2]);
// Read of size 0 doesn't affect things.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(0u, opj_read_from_memory(buffer, 0, &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Read exactly up to end of data.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(6u, opj_read_from_memory(buffer, 6, &dd));
EXPECT_EQ(0x02, buffer[0]);
EXPECT_EQ(0x03, buffer[1]);
EXPECT_EQ(0x84, buffer[2]);
EXPECT_EQ(0x85, buffer[3]);
EXPECT_EQ(0x86, buffer[4]);
EXPECT_EQ(0x87, buffer[5]);
EXPECT_EQ(0xbd, buffer[6]);
// Read of size 0 at EOF is still an error.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
}
TEST(fxcodec, DecodeDataReadBeyondBounds) {
uint8_t buffer[16];
{
DecodeData dd(stream_data, sizeof(stream_data));
// Read beyond bounds in a single step.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(8u, opj_read_from_memory(buffer, sizeof(buffer) + 1, &dd));
EXPECT_EQ(0x00, buffer[0]);
EXPECT_EQ(0x01, buffer[1]);
EXPECT_EQ(0x02, buffer[2]);
EXPECT_EQ(0x03, buffer[3]);
EXPECT_EQ(0x84, buffer[4]);
EXPECT_EQ(0x85, buffer[5]);
EXPECT_EQ(0x86, buffer[6]);
EXPECT_EQ(0x87, buffer[7]);
EXPECT_EQ(0xbd, buffer[8]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Read well beyond bounds in a single step.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(8u, opj_read_from_memory(
buffer, std::numeric_limits<OPJ_SIZE_T>::max(), &dd));
EXPECT_EQ(0x00, buffer[0]);
EXPECT_EQ(0x01, buffer[1]);
EXPECT_EQ(0x02, buffer[2]);
EXPECT_EQ(0x03, buffer[3]);
EXPECT_EQ(0x84, buffer[4]);
EXPECT_EQ(0x85, buffer[5]);
EXPECT_EQ(0x86, buffer[6]);
EXPECT_EQ(0x87, buffer[7]);
EXPECT_EQ(0xbd, buffer[8]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Read of size 6 gets first 6 bytes.
// rest of buffer intact.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(6u, opj_read_from_memory(buffer, 6, &dd));
EXPECT_EQ(0x00, buffer[0]);
EXPECT_EQ(0x01, buffer[1]);
EXPECT_EQ(0x02, buffer[2]);
EXPECT_EQ(0x03, buffer[3]);
EXPECT_EQ(0x84, buffer[4]);
EXPECT_EQ(0x85, buffer[5]);
EXPECT_EQ(0xbd, buffer[6]);
// Read of size 6 gets remaining two bytes.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(2u, opj_read_from_memory(buffer, 6, &dd));
EXPECT_EQ(0x86, buffer[0]);
EXPECT_EQ(0x87, buffer[1]);
EXPECT_EQ(0xbd, buffer[2]);
// Read of 6 more gets nothing and leaves rest of buffer intact.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 6, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
}
// Note: Some care needs to be taken here because the skip/seek functions
// take OPJ_OFF_T's as arguments, which are typically a signed type.
TEST(fxcodec, DecodeDataSkip) {
uint8_t buffer[16];
{
DecodeData dd(stream_data, sizeof(stream_data));
// Skiping within buffer is allowed.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(1u, opj_skip_from_memory(1, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x01, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Skiping 0 bytes changes nothing.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(0, opj_skip_from_memory(0, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x02, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Skiping to EOS-1 is possible.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(4u, opj_skip_from_memory(4, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x87, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Next read fails.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Skiping directly to EOS is allowed.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(8u, opj_skip_from_memory(8, &dd));
// Next read fails.
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Skipping beyond end of stream is allowed and returns full distance.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(9u, opj_skip_from_memory(9, &dd));
// Next read fails.
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Skipping way beyond EOS is allowd, doesn't wrap, and returns
// full distance.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(4u, opj_skip_from_memory(4, &dd));
EXPECT_EQ(std::numeric_limits<OPJ_OFF_T>::max(),
opj_skip_from_memory(std::numeric_limits<OPJ_OFF_T>::max(), &dd));
// Next read fails. If it succeeds, it may mean we wrapped.
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Negative skip within buffer not is allowed, position unchanged.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(4u, opj_skip_from_memory(4, &dd));
EXPECT_EQ(kSkipError, opj_skip_from_memory(-2, &dd));
// Next read succeeds as if nothing has happenned.
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x84, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Negative skip before buffer is not allowed, position unchanged.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(kSkipError, opj_skip_from_memory(-4, &dd));
// Next read succeeds as if nothing has happenned.
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x85, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Negative skip way before buffer is not allowed, doesn't wrap
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(4u, opj_skip_from_memory(4, &dd));
EXPECT_EQ(kSkipError,
opj_skip_from_memory(std::numeric_limits<OPJ_OFF_T>::min(), &dd));
// Next read succeeds. If it fails, it may mean we wrapped.
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x84, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
}
{
DecodeData dd(stream_data, sizeof(stream_data));
// Negative skip after EOS isn't alowed, still EOS.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_EQ(8u, opj_skip_from_memory(8, &dd));
EXPECT_EQ(kSkipError, opj_skip_from_memory(-4, &dd));
// Next read fails.
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
}
TEST(fxcodec, DecodeDataSeek) {
uint8_t buffer[16];
DecodeData dd(stream_data, sizeof(stream_data));
// Seeking within buffer is allowed and read succeeds
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_TRUE(opj_seek_from_memory(1, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x01, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Seeking before start returns error leaving position unchanged.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_FALSE(opj_seek_from_memory(-1, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x02, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Seeking way before start returns error leaving position unchanged.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_FALSE(
opj_seek_from_memory(std::numeric_limits<OPJ_OFF_T>::min(), &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x03, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Seeking exactly to EOS is allowed but read fails.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_TRUE(opj_seek_from_memory(8, &dd));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Seeking back to zero offset is allowed and read succeeds.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_TRUE(opj_seek_from_memory(0, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x00, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Seeking beyond end of stream is allowed but read fails.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_TRUE(opj_seek_from_memory(16, &dd));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
// Seeking within buffer after seek past EOF restores good state.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_TRUE(opj_seek_from_memory(4, &dd));
EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0x84, buffer[0]);
EXPECT_EQ(0xbd, buffer[1]);
// Seeking way beyond EOS is allowed, doesn't wrap, and read fails.
memset(buffer, 0xbd, sizeof(buffer));
EXPECT_TRUE(opj_seek_from_memory(std::numeric_limits<OPJ_OFF_T>::max(), &dd));
EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
EXPECT_EQ(0xbd, buffer[0]);
}
TEST(fxcodec, YUV420ToRGB) {
opj_image_comp_t u;
memset(&u, 0, sizeof(u));
u.dx = 1;
u.dy = 1;
u.w = 16;
u.h = 16;
u.prec = 8;
u.bpp = 8;
opj_image_comp_t v;
memset(&v, 0, sizeof(v));
v.dx = 1;
v.dy = 1;
v.w = 16;
v.h = 16;
v.prec = 8;
v.bpp = 8;
opj_image_comp_t y;
memset(&y, 0, sizeof(y));
y.dx = 1;
y.dy = 1;
y.prec = 8;
y.bpp = 8;
opj_image_t img;
memset(&img, 0, sizeof(img));
img.numcomps = 3;
img.color_space = OPJ_CLRSPC_SYCC;
img.comps = FX_Alloc(opj_image_comp_t, 3);
const struct {
OPJ_UINT32 w;
bool expected;
} cases[] = {{0, false}, {1, false}, {30, false}, {31, true},
{32, true}, {33, false}, {34, false}, {UINT_MAX, false}};
for (size_t i = 0; i < sizeof(cases) / sizeof(cases[0]); ++i) {
y.w = cases[i].w;
y.h = y.w;
img.x1 = y.w;
img.y1 = y.h;
y.data = static_cast<OPJ_INT32*>(opj_calloc(y.w * y.h, sizeof(OPJ_INT32)));
v.data = static_cast<OPJ_INT32*>(opj_calloc(v.w * v.h, sizeof(OPJ_INT32)));
u.data = static_cast<OPJ_INT32*>(opj_calloc(u.w * u.h, sizeof(OPJ_INT32)));
memset(y.data, 1, y.w * y.h * sizeof(OPJ_INT32));
memset(u.data, 0, u.w * u.h * sizeof(OPJ_INT32));
memset(v.data, 0, v.w * v.h * sizeof(OPJ_INT32));
img.comps[0] = y;
img.comps[1] = u;
img.comps[2] = v;
sycc420_to_rgb(&img);
if (cases[i].expected) {
EXPECT_EQ(img.comps[0].w, img.comps[1].w);
EXPECT_EQ(img.comps[0].h, img.comps[1].h);
EXPECT_EQ(img.comps[0].w, img.comps[2].w);
EXPECT_EQ(img.comps[0].h, img.comps[2].h);
} else {
EXPECT_NE(img.comps[0].w, img.comps[1].w);
EXPECT_NE(img.comps[0].h, img.comps[1].h);
EXPECT_NE(img.comps[0].w, img.comps[2].w);
EXPECT_NE(img.comps[0].h, img.comps[2].h);
}
opj_free(img.comps[0].data);
opj_free(img.comps[1].data);
opj_free(img.comps[2].data);
}
FX_Free(img.comps);
}
|