diff options
| author | Andrew McRae <amcrae@google.com> | 2019-09-19 16:55:52 +1000 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2019-09-21 01:22:20 +0000 |
| commit | 524bcbb494d5486470b993d7d717234d5781da03 (patch) | |
| tree | b74bcbd8c4a9fd9e5d033a53ee374db0440eb8ea | |
| parent | 31839f3c45d71ac03688cc7719287798eafb0996 (diff) | |
| download | coreboot-524bcbb494d5486470b993d7d717234d5781da03.tar.xz | |
drivers/wifi/generic.c: Upper case the AML WiFi name as required by spec
ACPI 6.3, ASL 20.2.2 (Name Objects Encoding) states:
LeadNameChar := 'A'-'Z' | '_'
NameChar := DigitChar | LeadNameChar
Hence, the Intel WiFi names generated in ASL are required to be
upper-cased letters.
BUG=b:141206986
TEST=Reflash and confirmed SSDT table has correct name.
Change-Id: I803b9bc81804eec7bd5220b9dbc6ddd0bb0ecbcc
Signed-off-by: Andrew McRae <amcrae@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35466
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/drivers/wifi/generic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/drivers/wifi/generic.c b/src/drivers/wifi/generic.c index b593ffe8bc..fc88f4a629 100644 --- a/src/drivers/wifi/generic.c +++ b/src/drivers/wifi/generic.c @@ -239,7 +239,8 @@ const char *generic_wifi_acpi_name(const struct device *dev) { static char wifi_acpi_name[WIFI_ACPI_NAME_MAX_LEN]; - snprintf(wifi_acpi_name, sizeof(wifi_acpi_name), "WF%02x", + /* ACPI 6.3, ASL 20.2.2: (Name Objects Encoding). */ + snprintf(wifi_acpi_name, sizeof(wifi_acpi_name), "WF%02X", (dev_path_encode(dev) & 0xff)); return wifi_acpi_name; } |