summaryrefslogtreecommitdiff
path: root/src/drivers/uart
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2018-11-11 01:42:17 +0100
committerNico Huber <nico.h@gmx.de>2018-11-21 22:49:48 +0000
commit755db95d1a36a4bd64519d7e05b00d62e848c458 (patch)
tree301582945323865890ae28e54ab8725592690618 /src/drivers/uart
parent7470c902d80d04730ac1147336339cc057db1be9 (diff)
downloadcoreboot-755db95d1a36a4bd64519d7e05b00d62e848c458.tar.xz
(console,drivers/uart)/Kconfig: Fix dependencies
The dependencies of CONSOLE_SERIAL and DRIVERS_UART were somehow backwards. Fix that. Now, CONSOLE_SERIAL depends on DRIVERS_UART, because it's using its interface. The individual UART drivers select DRIVERS_UART, because they implement the interface and depend on the common UART code. Some guards had to be fixed (using CONSOLE_SERIAL now instead of DRIVERS_UART). Some other guards that were only about compilation of units were removed. We want to build test as much as possible, right? Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/29572 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/drivers/uart')
-rw-r--r--src/drivers/uart/Kconfig5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig
index 1130aeb126..1f23a195f3 100644
--- a/src/drivers/uart/Kconfig
+++ b/src/drivers/uart/Kconfig
@@ -1,7 +1,5 @@
config DRIVERS_UART
bool
- default y if CONSOLE_SERIAL
- default n
config DRIVERS_UART_8250IO
# FIXME: Shouldn't have a prompt, should default to n, and
@@ -11,6 +9,7 @@ config DRIVERS_UART_8250IO
default n if DRIVERS_UART_8250MEM || HAVE_UART_SPECIAL
default n if NO_UART_ON_SUPERIO
default y
+ select DRIVERS_UART
config DRIVERS_UART_8250IO_SKIP_INIT
def_bool n
@@ -37,6 +36,7 @@ config UART_OVERRIDE_REFCLK
config DRIVERS_UART_8250MEM
bool
default n
+ select DRIVERS_UART
config DRIVERS_UART_8250MEM_32
bool
@@ -46,6 +46,7 @@ config DRIVERS_UART_8250MEM_32
config HAVE_UART_SPECIAL
bool
default n
+ select DRIVERS_UART
config DRIVERS_UART_OXPCIE
bool "Oxford OXPCIe952"