summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@chromium.org>2017-04-07 07:13:24 -0700
committerFurquan Shaikh <furquan@google.com>2017-04-09 21:35:53 +0200
commit5bda642bcb0fc6004f08d8acdfe0e71d5b3c5012 (patch)
tree3fa8c5bb5384ec5adc98d9dcd4195be4a7c063a1 /src/soc
parentbc17cdef0d3370f10f43ef45272399e3103eb01b (diff)
downloadcoreboot-5bda642bcb0fc6004f08d8acdfe0e71d5b3c5012.tar.xz
drivers/spi: Get rid of spi_get_config
There is only one user for spi_get_config i.e. SPI ACPI. Also, the values provided by spi_get_config are constant for now. Thus, get rid of the spi_get_config call and fill in these constant values in SPI ACPI code itself. If there is a need in the future to change these, appropriate device-tree configs can be added. BUG=b:36873582 Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819 Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/19203 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/common/block/gspi/gspi.c21
1 files changed, 0 insertions, 21 deletions
diff --git a/src/soc/intel/common/block/gspi/gspi.c b/src/soc/intel/common/block/gspi/gspi.c
index f3c146057e..74b94752b1 100644
--- a/src/soc/intel/common/block/gspi/gspi.c
+++ b/src/soc/intel/common/block/gspi/gspi.c
@@ -307,26 +307,6 @@ int __attribute__((weak)) gspi_get_soc_spi_cfg(unsigned int gspi_bus,
return 0;
}
-static int gspi_ctrlr_get_config(const struct spi_slave *dev,
- struct spi_cfg *cfg)
-{
- unsigned int gspi_bus;
-
- /* Currently, only chip select 0 is supported. */
- if (dev->cs != 0) {
- printk(BIOS_ERR, "%s: Invalid CS value: cs=%u.\n", __func__,
- dev->cs);
- return -1;
- }
-
- if (gspi_soc_spi_to_gspi_bus(dev->bus, &gspi_bus)) {
- printk(BIOS_ERR, "%s: Failed to find GSPI bus for SPI %u.\n",
- __func__, dev->bus);
- return -1;
- }
- return gspi_get_soc_spi_cfg(gspi_bus, cfg);
-}
-
static int gspi_cs_assert(const struct spi_slave *dev)
{
return gspi_cs_change(dev, CS_ASSERT);
@@ -627,7 +607,6 @@ static int gspi_ctrlr_xfer(const struct spi_slave *dev,
}
const struct spi_ctrlr gspi_ctrlr = {
- .get_config = gspi_ctrlr_get_config,
.claim_bus = gspi_cs_assert,
.release_bus = gspi_cs_deassert,
.setup = gspi_ctrlr_setup,