diff options
| author | Furquan Shaikh <furquan@google.com> | 2018-03-14 19:57:16 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2018-03-16 04:43:01 +0000 |
| commit | 6d5e10c05d99c475e63bbe95012066f9c585cfb3 (patch) | |
| tree | 8cecb6956bed707c4a8900ab79c491ad87982698 /src/soc | |
| parent | 211bb97c67ce704fb40abb6dd9971790652237e3 (diff) | |
| download | coreboot-6d5e10c05d99c475e63bbe95012066f9c585cfb3.tar.xz | |
soc/intel/apollolake and mainboards: Use pcie_rp_clkreq_pin array
This change uses an array pcie_rp_clkreq_pin for accepting CLKREQ#
from mainboards instead of defining a separate property for each root
port. This allows us to use memcpy to copy the entire array into FSP
params as well as new properties for PCIe root ports can be added as
arrays in future CLs.
BUG=b:74633273
BRANCH=reef,coral
Change-Id: Ifa05f1e38fcfd95063ec327712e472cdbd12dbb7
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/25186
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/apollolake/chip.c | 8 | ||||
| -rw-r--r-- | src/soc/intel/apollolake/chip.h | 8 |
2 files changed, 4 insertions, 12 deletions
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 53ffdb9f84..60067735ce 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -531,12 +531,8 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd) /* Parse device tree and disable unused device*/ parse_devicetree(silconfig); - silconfig->PcieRpClkReqNumber[0] = cfg->pcie_rp0_clkreq_pin; - silconfig->PcieRpClkReqNumber[1] = cfg->pcie_rp1_clkreq_pin; - silconfig->PcieRpClkReqNumber[2] = cfg->pcie_rp2_clkreq_pin; - silconfig->PcieRpClkReqNumber[3] = cfg->pcie_rp3_clkreq_pin; - silconfig->PcieRpClkReqNumber[4] = cfg->pcie_rp4_clkreq_pin; - silconfig->PcieRpClkReqNumber[5] = cfg->pcie_rp5_clkreq_pin; + memcpy(silconfig->PcieRpClkReqNumber, cfg->pcie_rp_clkreq_pin, + sizeof(silconfig->PcieRpClkReqNumber)); if (cfg->emmc_tx_cmd_cntl != 0) silconfig->EmmcTxCmdCntl = cfg->emmc_tx_cmd_cntl; diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 8573cf44b5..7a1d16a1ad 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -28,6 +28,7 @@ #include <soc/pm.h> #include <soc/usb.h> +#define MAX_PCIE_PORTS 6 #define CLKREQ_DISABLED 0xf #define APOLLOLAKE_I2C_DEV_MAX 8 @@ -43,12 +44,7 @@ struct soc_intel_apollolake_config { * four CLKREQ inputs, but six root ports. Root ports without an * associated CLKREQ signal must be marked with "CLKREQ_DISABLED" */ - uint8_t pcie_rp0_clkreq_pin; - uint8_t pcie_rp1_clkreq_pin; - uint8_t pcie_rp2_clkreq_pin; - uint8_t pcie_rp3_clkreq_pin; - uint8_t pcie_rp4_clkreq_pin; - uint8_t pcie_rp5_clkreq_pin; + uint8_t pcie_rp_clkreq_pin[MAX_PCIE_PORTS]; /* [14:8] DDR mode Number of dealy elements.Each = 125pSec. * [6:0] SDR mode Number of dealy elements.Each = 125pSec. |