summaryrefslogtreecommitdiff
path: root/src/vendorcode
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2020-08-25 16:00:44 -0700
committerJulius Werner <jwerner@chromium.org>2020-08-27 22:11:17 +0000
commit644a512e560147324ecf74ebce5e336bc57dd7bf (patch)
treeec9e63ea2fee79fb2be723568b4208fdcd35140a /src/vendorcode
parent8cc80d5e50c9382fb04041d7af9c1b59bba0184f (diff)
downloadcoreboot-644a512e560147324ecf74ebce5e336bc57dd7bf.tar.xz
symbols: Change implementation details of DECLARE_OPTIONAL_REGION()
It seems that GCC's LTO doesn't like the way we implement DECLARE_OPTIONAL_REGION(). This patch changes it so that rather than having a normal DECLARE_REGION() in <symbols.h> and then an extra DECLARE_OPTIONAL_REGION() in the C file using it, you just say DECLARE_OPTIONAL_REGION() directly in <symbols.h> (in place and instead of the usual DECLARE_REGION()). This basically looks the same way in the resulting object file but somehow LTO seems to like it better. Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I6096207b311d70c8e9956cd9406bec45be04a4a2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44791 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jacob Garber <jgarber1@ualberta.ca> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Diffstat (limited to 'src/vendorcode')
-rw-r--r--src/vendorcode/google/chromeos/symbols.h2
-rw-r--r--src/vendorcode/google/chromeos/watchdog.c2
2 files changed, 1 insertions, 3 deletions
diff --git a/src/vendorcode/google/chromeos/symbols.h b/src/vendorcode/google/chromeos/symbols.h
index 1e966da338..45f9c3e10b 100644
--- a/src/vendorcode/google/chromeos/symbols.h
+++ b/src/vendorcode/google/chromeos/symbols.h
@@ -5,6 +5,6 @@
#include <symbols.h>
-DECLARE_REGION(watchdog_tombstone)
+DECLARE_OPTIONAL_REGION(watchdog_tombstone)
#endif /* __CHROMEOS_SYMBOLS_H */
diff --git a/src/vendorcode/google/chromeos/watchdog.c b/src/vendorcode/google/chromeos/watchdog.c
index 5b3f1844a7..d3273cb442 100644
--- a/src/vendorcode/google/chromeos/watchdog.c
+++ b/src/vendorcode/google/chromeos/watchdog.c
@@ -14,8 +14,6 @@
#define WATCHDOG_TOMBSTONE_MAGIC 0x9d2f41a7
-DECLARE_OPTIONAL_REGION(watchdog_tombstone);
-
static void elog_handle_watchdog_tombstone(void *unused)
{
bool flag = false;