diff options
author | Furquan Shaikh <furquan@google.com> | 2018-05-02 23:29:04 -0700 |
---|---|---|
committer | Furquan Shaikh <furquan@google.com> | 2018-05-04 01:15:52 +0000 |
commit | c0257dd7ae9c8899b49c05ef74d9c5a91ee71d4f (patch) | |
tree | 1654b7ec1711748e63532b618ea73f9fc5233660 /util/ifdtool/ifdtool.h | |
parent | f658edf434421a2cb475c753c08e6d92e2be58c1 (diff) | |
download | coreboot-c0257dd7ae9c8899b49c05ef74d9c5a91ee71d4f.tar.xz |
ifdtool: Add a list of known platforms that support IFD_VERSION_2
ifdtool has relied on one of the fields within FCBA(read_freq) to
determine whether a platform supports IFD_VERSION_1 or
IFD_VERSION_2. However, newer platforms like GLK and CNL do not have
read_freq field in FCBA and so the value of these bits cannot be used
as an indicator to distinguish IFD versions. In the long run, we need
to re-write ifdtool to have a better mapping of SoC to IFD fields. But
until that is done, this change adds a list of platforms that we know
do not support read_freq field but still use IFD_VERSION_2. This
change also updates GLK and CNL to pass in platform parameter to
ifdtool.
BUG=b:79109029, b:69270831
Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/26023
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'util/ifdtool/ifdtool.h')
-rw-r--r-- | util/ifdtool/ifdtool.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index ad299a94f8..ef85555e06 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -22,7 +22,9 @@ enum ifd_version { }; enum platform { - PLATFORM_APOLLOLAKE, + PLATFORM_APL, + PLATFORM_CNL, + PLATFORM_GLK, PLATFORM_SKLKBL, }; |