summaryrefslogtreecommitdiff
path: root/util/ifdtool
diff options
context:
space:
mode:
authorBora Guvendik <bora.guvendik@intel.com>2019-02-12 13:07:45 -0800
committerPatrick Georgi <pgeorgi@google.com>2019-02-14 07:53:16 +0000
commit85ea91ae3cee3496905626f3d864a1eedfc55f95 (patch)
treea73fbd764c83fbed1a26daf1aa5406afc029aa24 /util/ifdtool
parent32bc1dc531712e187f830d84e6b03e8b8f5ed936 (diff)
downloadcoreboot-85ea91ae3cee3496905626f3d864a1eedfc55f95.tar.xz
util/ifdtools: Make EC region readable to BIOS/CPU
Allow EC region to be readable by BIOS/CPU so that flashrom can read it. BUG=b:123199222 TEST=Build coreboot with CONFIG_LOCK_MANAGEMENT_ENGINE set, run firmware_LockedME test. Change-Id: I306c74a0893355e57632a22a712b1f4fdaa19306 Signed-off-by: Bora Guvendik <bora.guvendik@intel.com> Reviewed-on: https://review.coreboot.org/c/31377 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'util/ifdtool')
-rw-r--r--util/ifdtool/ifdtool.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 85623fd3cb..a97f352bdf 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -969,8 +969,8 @@ static void lock_descriptor(const char *filename, char *image, int size)
case PLATFORM_CNL:
case PLATFORM_ICL:
case PLATFORM_SKLKBL:
- /* CPU/BIOS can read descriptor, BIOS and GbE. */
- fmba->flmstr1 |= 0xb << rd_shift;
+ /* CPU/BIOS can read descriptor, BIOS, EC and GbE. */
+ fmba->flmstr1 |= 0x10b << rd_shift;
/* CPU/BIOS can write BIOS and Gbe. */
fmba->flmstr1 |= 0xa << wr_shift;
/* ME can read descriptor, ME and GbE. */