diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2016-11-30 20:07:50 +0100 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2017-01-03 12:22:47 +0100 |
| commit | 63042a718887693a07e6575fc8c8f58cdd0933cc (patch) | |
| tree | 0ca61dffd680753f784124ebf5c4b0651ff8fd19 | |
| parent | 7c6075e2546dd818b7b87090a983429b1942796a (diff) | |
| download | edk2-platforms-63042a718887693a07e6575fc8c8f58cdd0933cc.tar.xz | |
MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit LoopTimes
The BaseNull instance of S3BootScriptLib obviously doesn't care about the
type of the S3BootScriptSaveMemPoll() function's LoopTimes parameter; this
lib instance doesn't do anything with the parameters received in
S3BootScriptSaveMemPoll().
The PiDxe instance saves the LoopTimes parameter in
EFI_BOOT_SCRIPT_MEM_POLL.LoopTimes. This target field already has UINT64
type. Furthermore, the BootScriptExecuteMemPoll() function in the same
library instance already uses a local UINT64 variable called LoopTimes to
count up to EFI_BOOT_SCRIPT_MEM_POLL.LoopTimes. This means that the the
UINTN type for S3BootScriptSaveMemPoll()'s LoopTimes parameter is an
unnecessary restriction.
The callers of S3BootScriptSaveMemPoll() will be updated in the next
patches, functionally. At this stage, they will continue to compile, since
UINT64 parameters can accept UINTN arguments.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: "Yao, Jiewen" <jiewen.yao@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
| -rw-r--r-- | MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c | 2 | ||||
| -rw-r--r-- | MdePkg/Include/Library/S3BootScriptLib.h | 2 | ||||
| -rw-r--r-- | MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c b/MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c index 9ff5b80e7a..5698c91663 100644 --- a/MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c +++ b/MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c @@ -1672,7 +1672,7 @@ S3BootScriptSaveMemPoll ( IN VOID *BitMask,
IN VOID *BitValue,
IN UINTN Duration,
- IN UINTN LoopTimes
+ IN UINT64 LoopTimes
)
{
UINT8 Length;
diff --git a/MdePkg/Include/Library/S3BootScriptLib.h b/MdePkg/Include/Library/S3BootScriptLib.h index 0a8cbe355a..3f43da8794 100644 --- a/MdePkg/Include/Library/S3BootScriptLib.h +++ b/MdePkg/Include/Library/S3BootScriptLib.h @@ -343,7 +343,7 @@ S3BootScriptSaveMemPoll ( IN VOID *BitMask,
IN VOID *BitValue,
IN UINTN Duration,
- IN UINTN LoopTimes
+ IN UINT64 LoopTimes
);
/**
diff --git a/MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c b/MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c index 373ce6b388..3dee64746a 100644 --- a/MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c +++ b/MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c @@ -303,7 +303,7 @@ S3BootScriptSaveMemPoll ( IN VOID *BitMask,
IN VOID *BitValue,
IN UINTN Duration,
- IN UINTN LoopTimes
+ IN UINT64 LoopTimes
)
{
return RETURN_SUCCESS;
|