diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2016-05-13 17:50:42 +0800 |
|---|---|---|
| committer | Liming Gao <liming.gao@intel.com> | 2016-05-17 10:09:53 +0800 |
| commit | 7b13510f2a0a2a118cdafdaa67720ca8e3fe37de (patch) | |
| tree | a256528e76f0492b3bba180fd804f5f5af95be12 | |
| parent | 17da28f3e2451524ebf50b55ee302b5d0abdb98e (diff) | |
| download | edk2-platforms-7b13510f2a0a2a118cdafdaa67720ca8e3fe37de.tar.xz | |
MdeModulePkg/BootMaintenanceManagerUiLib: hide library-internal symbol
Static storage duration objects that are internal to a library instance
should:
- either have internal linkage (i.e., be declared STATIC),
- or, if they are referenced in multiple files of the library instance,
prefixed with a word that is specific to the library instance, and
minimizes namespace collisions.
In this case, the "gHiiDriverList" variable (with static storage duration
and external linkage) is defined in both BootMaintenanceManagerUiLib and
UiApp. When these are linked together, GCC catches the multiple external
definitions and aborts the build. (GCC notices this due to commit
214a3b79417f.) Fix the error by applying the first rule above.
Fixes: a85be3ae48a8aaa40b755cd0ff7270c67cfed585
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
| -rw-r--r-- | MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c index 177b2498d3..fefb714b91 100644 --- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c +++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c @@ -26,7 +26,7 @@ typedef struct { BOOLEAN EmptyLineAfter;
} UI_HII_DRIVER_INSTANCE;
-UI_HII_DRIVER_INSTANCE *gHiiDriverList;
+STATIC UI_HII_DRIVER_INSTANCE *gHiiDriverList;
/**
|