diff options
| author | oliviermartin <oliviermartin@6f19259b-4bc3-4df7-8a09-765794883524> | 2012-05-02 19:52:49 +0000 |
|---|---|---|
| committer | oliviermartin <oliviermartin@6f19259b-4bc3-4df7-8a09-765794883524> | 2012-05-02 19:52:49 +0000 |
| commit | 3f305c063a3bf3ce556b939da31fb99a526d768c (patch) | |
| tree | 7e4de94b2421178106306cb67131ddaa732137b2 /ArmPlatformPkg/Drivers/SP805WatchdogDxe | |
| parent | d9efd68ef54883f8142d833212d66870248c0dd7 (diff) | |
| download | edk2-platforms-3f305c063a3bf3ce556b939da31fb99a526d768c.tar.xz | |
ArmPlatformPkg: Removed the 'Identify' functions
This function was introduced in some drivers to check if the ARM controller
was present in the memory map.
It was using a 8 bit access to get the value from the Identification registers.
These accesses could generate access error on some buses. Instead of replacing
the 8bit access by a 32bit access, these fcuntions have been removed because
they are only useful when the boot firmware is ported on a new platform.
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13247 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ArmPlatformPkg/Drivers/SP805WatchdogDxe')
| -rw-r--r-- | ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c | 33 |
1 files changed, 1 insertions, 32 deletions
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c index a9ec88c333..5b78b2b3f4 100644 --- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c +++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c @@ -29,30 +29,6 @@ EFI_EVENT EfiExitBootServicesEvent = (EFI_EVENT)NULL; -EFI_STATUS -SP805Identify ( - VOID - ) -{ - // Check if this is a PrimeCell Peripheral - if ( (MmioRead8 (SP805_WDOG_PCELL_ID0) != 0x0D) - || (MmioRead8 (SP805_WDOG_PCELL_ID1) != 0xF0) - || (MmioRead8 (SP805_WDOG_PCELL_ID2) != 0x05) - || (MmioRead8 (SP805_WDOG_PCELL_ID3) != 0xB1)) { - return EFI_NOT_FOUND; - } - - // Check if this PrimeCell Peripheral is the SP805 Watchdog Timer - if ( (MmioRead8 (SP805_WDOG_PERIPH_ID0) != 0x05) - || (MmioRead8 (SP805_WDOG_PERIPH_ID1) != 0x18) - || ((MmioRead8 (SP805_WDOG_PERIPH_ID2) & 0x0000000F) != 0x04) - || (MmioRead8 (SP805_WDOG_PERIPH_ID3) != 0x00)) { - return EFI_NOT_FOUND; - } - - return EFI_SUCCESS; -} - /** Make sure the SP805 registers are unlocked for writing. @@ -363,13 +339,6 @@ SP805Initialize ( EFI_STATUS Status; EFI_HANDLE Handle; - // Check if the SP805 hardware watchdog module exists on board - Status = SP805Identify(); - if (EFI_ERROR(Status)) { - Status = EFI_DEVICE_ERROR; - goto EXIT; - } - // Unlock access to the SP805 registers SP805Unlock (); @@ -409,7 +378,7 @@ SP805Initialize ( goto EXIT; } - EXIT: +EXIT: if(EFI_ERROR(Status)) { // The watchdog failed to initialize ASSERT(FALSE); |