diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2016-01-19 10:46:34 +0000 |
|---|---|---|
| committer | lersek <lersek@Edk2> | 2016-01-19 10:46:34 +0000 |
| commit | dfc229f6a67b03e3c47b67b92982a100cfef738a (patch) | |
| tree | 90555ba0e9e0e6fea8a1a15e7462d97e9be0c29b /BaseTools/Source/Python | |
| parent | 3b672240e6c77ccf3f5cc0f3e8dbf026fc9e2751 (diff) | |
| download | edk2-platforms-dfc229f6a67b03e3c47b67b92982a100cfef738a.tar.xz | |
MdeModulePkg/.../IdeMode: actualize DRQReady*() comment blocks
The DRQReady() and DRQReady2() functions only differ in that they poll
different status registers for BSY, ERR, and DRQ: the former looks at the
Status Register (clearing interrupt status), while the latter looks at the
Alternate Status Register (not clearing interrupt status).
They both correctly return a unique status code, EFI_NOT_READY, for the
BSY==0 && ERR==0 && DRQ==0
case; that is, when the device reports "command complete".
However, the functions' leading comments don't explain this case, so it's
easy to miss in callers. Update the comments.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: John Snow <jsnow@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19684 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'BaseTools/Source/Python')
0 files changed, 0 insertions, 0 deletions