diff options
author | Ruiyu Ni <ruiyu.ni@intel.com> | 2017-06-01 18:27:23 +0800 |
---|---|---|
committer | Guo Mang <mang.guo@intel.com> | 2017-07-12 11:24:51 +0800 |
commit | 645232ba02bcb48e35803ae70ce607ac5109d90d (patch) | |
tree | ed03971273501209469e190ab3d947424ee065cf /Core/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | |
parent | 77a200eaa84d4c6d6d6f2d62ee5f9eb10d6e3716 (diff) | |
download | edk2-platforms-645232ba02bcb48e35803ae70ce607ac5109d90d.tar.xz |
MdeModulePkg/UsbBus: Fix system hang when failed to uninstall UsbIo
When "reconnect -r" is typed in shell, UsbFreeInterface() is called
to uninstall the UsbIo and DevicePath. But When a UsbIo is opened
by a driver and that driver rejects to close the UsbIo in Stop(),
the uninstall doesn't succeed.
But UsbFreeInterface () frees the DevicePath memory without check
whether the uninstall succeeds.
It leads to the DXE core database contain a DevicePath instance but
that instance's memory is freed.
Assertion happens when someone calls InstallProtocol(DevicePath)
because the InstallProtocol() checks all DevicePath instance to
find whether the same one exits in database.
We haven't seen any USB device driver which rejects to close UsbIo
in Stop(), but it's very likely.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
(cherry picked from commit b659b503fa7c43677ccab40d311dbab33366ee97)
Diffstat (limited to 'Core/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c')
0 files changed, 0 insertions, 0 deletions