diff options
| author | hfang <hfang@6f19259b-4bc3-4df7-8a09-765794883524> | 2009-01-08 08:48:15 +0000 |
|---|---|---|
| committer | hfang <hfang@6f19259b-4bc3-4df7-8a09-765794883524> | 2009-01-08 08:48:15 +0000 |
| commit | eeefcb9d4bbe0282ce9efeba838596e9c5a2f809 (patch) | |
| tree | 4c6436d724f23f379d69c97ce05d7b9c87911a0a /IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c | |
| parent | 2895c5060c0dbdffefd5131905b906ee0772ade9 (diff) | |
| download | edk2-platforms-eeefcb9d4bbe0282ce9efeba838596e9c5a2f809.tar.xz | |
Update For R9 Review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7215 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c')
| -rw-r--r-- | IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 32 |
1 files changed, 20 insertions, 12 deletions
diff --git a/IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c index 68e507aceb..43a8fb34bb 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/IntelFrameworkModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -1,4 +1,4 @@ -/**@file
+/** @file
Implement all interfaces for EFI_PCI_IO_PROTOCOL.
Copyright (c) 2006 - 2008, Intel Corporation
@@ -18,6 +18,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. //
// Internal use only
//
+/**
+ report a error Status code of PCI bus driver controller.
+
+ @param PciIoDevice Pci device instance.
+ @param Code status code.
+**/
EFI_STATUS
ReportErrorStatusCode (
IN PCI_IO_DEVICE *PciIoDevice,
@@ -61,10 +67,10 @@ EFI_PCI_IO_PROTOCOL PciIoInterface = { };
/**
- report a error Status code of PCI bus driver controller
+ report a error Status code of PCI bus driver controller.
- @param PciIoDevice Pci device instance
- @param Code status code
+ @param PciIoDevice Pci device instance.
+ @param Code status code.
**/
EFI_STATUS
ReportErrorStatusCode (
@@ -80,11 +86,11 @@ ReportErrorStatusCode ( }
/**
- Initializes a PCI I/O Instance
+ Initializes a PCI I/O Instance.
- @param PciIoDevice Pci device instance
+ @param PciIoDevice Pci device instance.
- @retval EFI_SUCCESS Success operation
+ @retval EFI_SUCCESS Success operation.
**/
EFI_STATUS
InitializePciIoInstance (
@@ -281,7 +287,9 @@ PciIoPollMem ( @param This A pointer to the EFI_PCI_IO_PROTOCOL.
@param Width Signifies the width of the memory or I/O operations.
- @param Address The base address of the memory or I/O operations.
+ @param BarIndex The BAR index of the standard PCI Configuration header to use as the
+ base address for the memory or I/O operation to perform.
+ @param Offset The offset within the selected BAR to start the memory or I/O operation.
@param Mask Mask used for the polling criteria.
@param Value The comparison value used for the polling exit criteria.
@param Delay The number of 100 ns units to poll.
@@ -1459,7 +1467,7 @@ PciIoAttributes ( // Check if there have been an active VGA device on the same segment
//
Temp = ActiveVGADeviceOnTheSameSegment (PciIoDevice);
- if (Temp && Temp != PciIoDevice) {
+ if (Temp != NULL && Temp != PciIoDevice) {
//
// An active VGA has been detected, so can not enable another
//
@@ -1529,7 +1537,7 @@ PciIoAttributes ( // Enable relevant attributes to command register and bridge control register
//
Status = PciEnableCommandRegister (PciIoDevice, Command);
- if (BridgeControl) {
+ if (BridgeControl != 0) {
Status = PciEnableBridgeControlRegister (PciIoDevice, BridgeControl);
}
@@ -1550,7 +1558,7 @@ PciIoAttributes ( // Disable relevant attributes to command register and bridge control register
//
Status = PciDisableCommandRegister (PciIoDevice, Command);
- if (BridgeControl) {
+ if (BridgeControl != 0) {
Status = PciDisableBridgeControlRegister (PciIoDevice, BridgeControl);
}
@@ -1838,7 +1846,7 @@ UpStreamBridgesAttributes ( Parent = PciIoDevice->Parent;
- while (Parent && IS_PCI_BRIDGE (&Parent->Pci)) {
+ while (Parent != NULL && IS_PCI_BRIDGE (&Parent->Pci)) {
//
// Get the PciIo Protocol
|