summaryrefslogtreecommitdiff
path: root/IntelFspPkg
diff options
context:
space:
mode:
authorYao, Jiewen <Jiewen.Yao@intel.com>2015-05-01 01:05:00 +0000
committerjyao1 <jyao1@Edk2>2015-05-01 01:05:00 +0000
commit12a92f51f0efaa0c4f7abdaf869984ae1c65f430 (patch)
treee44bd39ec5b64b2eb707c6fbe95fbff4f1bb9934 /IntelFspPkg
parent6f7878a97281299bf4a052687a177dfbee4b0de1 (diff)
downloadedk2-platforms-12a92f51f0efaa0c4f7abdaf869984ae1c65f430.tar.xz
Fix FSP GCC error on FspApiCallingCheck().
Add comment for ASM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" <Jiewen.Yao@intel.com> Reviewed-by: "Mudusuru, Giri P" <giri.p.mudusuru@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17281 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'IntelFspPkg')
-rw-r--r--IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm4
-rw-r--r--IntelFspPkg/FspSecCore/Ia32/FspApiEntry.s5
2 files changed, 5 insertions, 4 deletions
diff --git a/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm b/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm
index a01b3c2d49..a0c9b1ed73 100644
--- a/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm
+++ b/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm
@@ -489,8 +489,8 @@ FspApiCommon PROC C PUBLIC
; Verify the calling condition
;
pushad
- push [esp + 4 * 8 + 4]
- push eax
+ push [esp + 4 * 8 + 4] ; push ApiParam
+ push eax ; push ApiIdx
call FspApiCallingCheck
add esp, 8
cmp eax, 0
diff --git a/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.s b/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.s
index e7b82d5e93..8f4093ca19 100644
--- a/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.s
+++ b/IntelFspPkg/FspSecCore/Ia32/FspApiEntry.s
@@ -703,9 +703,10 @@ FspApiCommonL0:
# Verify the calling condition
#
pushal
- pushl %eax
+ pushl 36(%esp) #push ApiParam [esp + 4 * 8 + 4]
+ pushl %eax #push ApiIdx
call ASM_PFX(FspApiCallingCheck)
- addl $0x04, %esp
+ addl $0x08, %esp
cmpl $0x00, %eax
jz FspApiCommonL1
movl %eax, 0x1C(%esp) # mov dword ptr [esp + 4 * 7], eax