diff options
| author | Star Zeng <star.zeng@intel.com> | 2015-11-18 10:13:31 +0000 |
|---|---|---|
| committer | lzeng14 <lzeng14@Edk2> | 2015-11-18 10:13:31 +0000 |
| commit | 305d3c8e8da4b0bb0f3f8d216d8ac91fe33d5464 (patch) | |
| tree | 8e502c392d96a819af42b431b63f6e2b9040cc17 /MdeModulePkg/Core | |
| parent | 48b77f5ea9091d78098ba0d6168d4b638914f280 (diff) | |
| download | edk2-platforms-305d3c8e8da4b0bb0f3f8d216d8ac91fe33d5464.tar.xz | |
MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call
The ASSERT (PrivateData->PeiMemoryInstalled) in if (PrivateData->PeiMemoryInstalled)
condition is useless, it should be ASSERT (FALSE) to follow the code's expectation.
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18887 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'MdeModulePkg/Core')
| -rw-r--r-- | MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c index 36bdc73ebd..2f9b9dea31 100644 --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c @@ -96,7 +96,7 @@ PeiInstallPeiMemory ( //
if (PrivateData->PeiMemoryInstalled) {
DEBUG ((EFI_D_ERROR, "ERROR: PeiInstallPeiMemory is called more than once!\n"));
- ASSERT (PrivateData->PeiMemoryInstalled);
+ ASSERT (FALSE);
return EFI_SUCCESS;
}
|