Remove SafeFreePool from MemoryAllocationLib as this API's name is misleading. Its implementation only check if a pointer is NULL. If a garbage pointer is passed in, the gBS->FreePool will still ASSERT in debug build and return error code.

It is recommended that module writer should keep track how a pointer is allocated and free it after use.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6306 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 7 insertions, 3 deletions

diff --git a/MdeModulePkg/Library/GenericBdsLib/BdsConnect.c b/MdeModulePkg/Library/GenericBdsLib/BdsConnect.c
index 5e7d13fb82..66b09ee465 100644
--- a/MdeModulePkg/Library/GenericBdsLib/BdsConnect.c
+++ b/MdeModulePkg/Library/GenericBdsLib/BdsConnect.c
@@ -176,7 +176,7 @@ BdsLibConnectDevicePath (
   } while (DevicePath != NULL);

 

   if (CopyOfDevicePath != NULL) {

-    SafeFreePool (CopyOfDevicePath);

+    FreePool (CopyOfDevicePath);

   }

   //

   // All handle with DevicePath exists in the handle database

@@ -220,7 +220,9 @@ BdsLibConnectAllEfi (
     Status = gBS->ConnectController (HandleBuffer[Index], NULL, NULL, TRUE);

   }

 

-  SafeFreePool (HandleBuffer);

+  if (HandleBuffer != NULL) {

+    FreePool (HandleBuffer);

+  }

 

   return EFI_SUCCESS;

 }

@@ -263,7 +265,9 @@ BdsLibDisconnectAllEfi (
     Status = gBS->DisconnectController (HandleBuffer[Index], NULL, NULL);

   }

 

-  SafeFreePool (HandleBuffer);

+  if (HandleBuffer != NULL) {

+    FreePool (HandleBuffer);

+  }

 

   return EFI_SUCCESS;

 }