diff options
| author | Star Zeng <star.zeng@intel.com> | 2015-11-19 02:32:03 +0000 |
|---|---|---|
| committer | vanjeff <vanjeff@Edk2> | 2015-11-19 02:32:03 +0000 |
| commit | 04d5cc639b207b0d3b9922acc7c669fffe25ef79 (patch) | |
| tree | 173b515d5cbbe053f4be81a9dd6385f33adc0521 /MdeModulePkg | |
| parent | 8021dff6657c6330d80e38c53c256cd96e43b35f (diff) | |
| download | edk2-platforms-04d5cc639b207b0d3b9922acc7c669fffe25ef79.tar.xz | |
MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call
The ASSERT (PrivateData->PeiMemoryInstalled) in if (PrivateData->PeiMemoryInstalled)
condition is useless, it should be ASSERT (FALSE) to follow the code's expectation.
(Sync patch r18887 from main trunk.)
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/branches/UDK2015@18901 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'MdeModulePkg')
| -rw-r--r-- | MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c index 36bdc73ebd..2f9b9dea31 100644 --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c @@ -96,7 +96,7 @@ PeiInstallPeiMemory ( //
if (PrivateData->PeiMemoryInstalled) {
DEBUG ((EFI_D_ERROR, "ERROR: PeiInstallPeiMemory is called more than once!\n"));
- ASSERT (PrivateData->PeiMemoryInstalled);
+ ASSERT (FALSE);
return EFI_SUCCESS;
}
|