1. UINTN & INTN issue for EBC architecture:

	The MAX_BIT of EBC will no longer be fixed to bit 63. It is defined as (1ULL << (sizeof (INTN) * 8 - 1)).
	Make EdkModulePkg & MdePkg EBC compiler clean: treat all EFI_STATUS error code as variable.
2. PrintLib
	Complete all missing ASSERT()s.
	Fix “\n” & “%\n” issue thanks to the clarification of MWG 0.56d.
	Adjust StatusString array to support EBC build.
3. BaseMemoryLib
	Adjust ASSERT () & function header of ComparaMem, SetMemXX, ScanMemXX to synchronize with MWG 0.56d.
4.SmbusLib
	Change Pec bit to bit 22 SmBusAddress to synchronize MWG 0.56d.
	Add ASSERT()s to check if length is illegal for SmBusBlockWrite() & SmBusProcessBlock() since it is 6 bit now.
5. PerformanceLib
	Rename “EdkDxePerformanceLib” & “EdkPeiPerformanceLib” to “DxePerformanceLib” & “PeiPerformanceLib” respectively.
	Synchronize the function header of GetPerformanceMeasurement() with MWG 0.56d.
6. BasePeCoffLoaderLib.
	Make PeCoffLoaderLoadImage () Assert() if ImageContext is NULL>
	Make PeCoffLoaderLoadImage () return RETURN_INVALID_PARAMETER if the ImageAddress in ImageContext is 0.
	Adjust some coding style.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@593 6f19259b-4bc3-4df7-8a09-765794883524

2 files changed, 23 insertions, 21 deletions

diff --git a/MdePkg/Library/PeiSmbusLib/InternalSmbusLib.h b/MdePkg/Library/PeiSmbusLib/InternalSmbusLib.h
index bd6d57f2d3..47c00a7306 100644
--- a/MdePkg/Library/PeiSmbusLib/InternalSmbusLib.h
+++ b/MdePkg/Library/PeiSmbusLib/InternalSmbusLib.h
@@ -11,8 +11,6 @@ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.             

 

 

-Module Name: SmbusLib.c

-

 **/

 

 #ifndef __INTERNAL_SMBUS_LIB_H

@@ -20,9 +18,9 @@ Module Name: SmbusLib.c
 

 #define SMBUS_LIB_SLAVE_ADDRESS(SmBusAddress)      (((SmBusAddress) >> 1)  & 0x7f)

 #define SMBUS_LIB_COMMAND(SmBusAddress)            (((SmBusAddress) >> 8)  & 0xff)

-#define SMBUS_LIB_LENGTH(SmBusAddress)             (((SmBusAddress) >> 16) & 0x1f)

+#define SMBUS_LIB_LENGTH(SmBusAddress)             (((SmBusAddress) >> 16) & 0x3f)

 #define SMBUS_LIB_PEC(SmBusAddress)     ((BOOLEAN) (((SmBusAddress) & SMBUS_LIB_PEC_BIT) != 0))

-#define SMBUS_LIB_RESEARVED(SmBusAddress)          ((SmBusAddress) & ~(((1 << 21) - 2) | SMBUS_LIB_PEC_BIT))

+#define SMBUS_LIB_RESEARVED(SmBusAddress)          ((SmBusAddress) & ~(((1 << 22) - 2) | SMBUS_LIB_PEC_BIT))

 

 //

 // Declaration for internal functions

diff --git a/MdePkg/Library/PeiSmbusLib/SmbusLib.c b/MdePkg/Library/PeiSmbusLib/SmbusLib.c
index e71f11bef8..93fadb6598 100644
--- a/MdePkg/Library/PeiSmbusLib/SmbusLib.c
+++ b/MdePkg/Library/PeiSmbusLib/SmbusLib.c
@@ -350,7 +350,7 @@ SmBusProcessCall (
   Bytes are read from the SMBUS and stored in Buffer.

   The number of bytes read is returned, and will never return a value larger than 32-bytes.

   If Status is not NULL, then the status of the executed command is returned in Status.

-  It is the caller��s responsibility to make sure Buffer is large enough for the total number of bytes read.

+  It is the caller's responsibility to make sure Buffer is large enough for the total number of bytes read.

   SMBUS supports a maximum transfer size of 32 bytes, so Buffer does not need to be any larger than 32 bytes.

   If Length in SmBusAddress is not zero, then ASSERT().

   If Buffer is NULL, then ASSERT().

@@ -412,9 +412,11 @@ SmBusWriteBlock (
   UINTN  Length;

 

   ASSERT (Buffer != NULL);

+  ASSERT (SMBUS_LIB_LENGTH (SmBusAddress) >= 1);

+  ASSERT (SMBUS_LIB_LENGTH (SmBusAddress) <= 32);

   ASSERT (SMBUS_LIB_RESEARVED (SmBusAddress) == 0);

 

-  Length = SMBUS_LIB_LENGTH (SmBusAddress) + 1;

+  Length = SMBUS_LIB_LENGTH (SmBusAddress);

   return InternalSmBusExec (EfiSmbusWriteBlock, SmBusAddress, Length, Buffer, Status);

 }

 

@@ -423,19 +425,19 @@ SmBusWriteBlock (
 

   Executes an SMBUS block process call command on the SMBUS device specified by SmBusAddress.

   The SMBUS slave address, SMBUS command, and SMBUS length fields of SmBusAddress are required.

-  Bytes are written to the SMBUS from OutBuffer.  Bytes are then read from the SMBUS into InBuffer.

+  Bytes are written to the SMBUS from WriteBuffer.  Bytes are then read from the SMBUS into ReadBuffer.

   If Status is not NULL, then the status of the executed command is returned in Status.

-  It is the caller��s responsibility to make sure InBuffer is large enough for the total number of bytes read.

+  It is the caller's responsibility to make sure ReadBuffer is large enough for the total number of bytes read.

   SMBUS supports a maximum transfer size of 32 bytes, so Buffer does not need to be any larger than 32 bytes.

-  If OutBuffer is NULL, then ASSERT().

-  If InBuffer is NULL, then ASSERT().

+  If Length in SmBusAddress is zero or greater than 32, then ASSERT().

+  If WriteBuffer is NULL, then ASSERT().

+  If ReadBuffer is NULL, then ASSERT().

   If any reserved bits of SmBusAddress are set, then ASSERT().

 

-

   @param  SmBusAddress    Address that encodes the SMBUS Slave Address,

                           SMBUS Command, SMBUS Data Length, and PEC.

-  @param  OutBuffer       Pointer to the buffer of bytes to write to the SMBUS.

-  @param  InBuffer        Pointer to the buffer of bytes to read from the SMBUS.

+  @param  WriteBuffer     Pointer to the buffer of bytes to write to the SMBUS.

+  @param  ReadBuffer      Pointer to the buffer of bytes to read from the SMBUS.

   @param  Status          Return status for the executed command.

                           This is an optional parameter and may be NULL.

 

@@ -446,21 +448,23 @@ UINTN
 EFIAPI

 SmBusBlockProcessCall (

   IN  UINTN          SmBusAddress,

-  IN  VOID           *OutBuffer,

-  OUT VOID           *InBuffer,

+  IN  VOID           *WriteBuffer,

+  OUT VOID           *ReadBuffer,

   OUT RETURN_STATUS  *Status        OPTIONAL

   )

 {

   UINTN   Length;

 

-  ASSERT (InBuffer  != NULL);

-  ASSERT (OutBuffer != NULL);

+  ASSERT (WriteBuffer != NULL);

+  ASSERT (ReadBuffer  != NULL);

+  ASSERT (SMBUS_LIB_LENGTH (SmBusAddress) >= 1);

+  ASSERT (SMBUS_LIB_LENGTH (SmBusAddress) <= 32);

   ASSERT (SMBUS_LIB_RESEARVED (SmBusAddress) == 0);

 

-  Length   = SMBUS_LIB_LENGTH (SmBusAddress) + 1;

+  Length = SMBUS_LIB_LENGTH (SmBusAddress);

   //

-  // Assuming that InBuffer is large enough to save another memory copy.

+  // Assuming that ReadBuffer is large enough to save another memory copy.

   //

-  InBuffer = CopyMem (InBuffer, OutBuffer, Length);

-  return InternalSmBusExec (EfiSmbusBWBRProcessCall, SmBusAddress, Length, InBuffer, Status);

+  ReadBuffer = CopyMem (ReadBuffer, WriteBuffer, Length);

+  return InternalSmBusExec (EfiSmbusBWBRProcessCall, SmBusAddress, Length, ReadBuffer, Status);

 }