diff options
| author | wang xiaofeng <winggundum82@163.com> | 2016-05-13 11:20:28 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2016-05-15 17:45:25 +0800 |
| commit | dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254 (patch) | |
| tree | 24cfcece7fc6915b79a8780f32ac7a25e8921bc3 /PcAtChipsetPkg | |
| parent | aa52bace8f4aedb3172dbabb8fed71841e108abd (diff) | |
| download | edk2-platforms-dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254.tar.xz | |
PcAtChipsetPkg AcpiTimerLib: Fix a logic error
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) &
EnableMask) != EnableMask)) {
The bracket place is not right, I think it should be
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) &
EnableMask) != EnableMask)
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: wang xiaofeng <winggundum82@163.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Diffstat (limited to 'PcAtChipsetPkg')
| -rw-r--r-- | PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c index ad855fe4f5..806a4f7ce2 100644 --- a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c +++ b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c @@ -89,7 +89,7 @@ AcpiTimerLibConstructor ( //
// If ACPI I/O space is not enabled yet, program ACPI I/O base address and enable it.
//
- if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & EnableMask) != EnableMask)) {
+ if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & EnableMask) != EnableMask) {
PciWrite16 (
PCI_LIB_ADDRESS (Bus, Device, Function, PcdGet16 (PcdAcpiIoPciBarRegisterOffset)),
PcdGet16 (PcdAcpiIoPortBaseAddress)
|