Handle TPM device error and avoid deadloop in BDS.

If TPM error happens, set TPM flag to NOT present, so that trusted boot patch is disabled.
Also report status code for failure, so that platform may register handler to apply policy like force system reset, or disable TPM permanently.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen" <jiewen.yao@intel.com>
Reviewed-by: "Dong, Guo" <guo.dong@intel.com>




git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16598 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 17 insertions, 29 deletions

diff --git a/SecurityPkg/Tcg/TrEEPei/TrEEPei.c b/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
index 8e2bc748ff..eea40847c5 100644
--- a/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
+++ b/SecurityPkg/Tcg/TrEEPei/TrEEPei.c
@@ -1,7 +1,7 @@
 /** @file

   Initialize TPM2 device and measure FVs before handing off control to DXE.

 

-Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.<BR>

 This program and the accompanying materials 

 are licensed and made available under the terms and conditions of the BSD License 

 which accompanies this distribution.  The full text of the license may be found at 

@@ -40,19 +40,17 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Protocol/TrEEProtocol.h>

 #include <Library/PerformanceLib.h>

 #include <Library/MemoryAllocationLib.h>

+#include <Library/ReportStatusCodeLib.h>

 

 #define PERF_ID_TREE_PEI  0x3080

 

 typedef struct {

   EFI_GUID               *EventGuid;

   TREE_EVENT_LOG_FORMAT  LogFormat;

-  UINT32                 BootHashAlg;

-  UINT16                 DigestAlgID;

-  TPMI_ALG_HASH          TpmHashAlgo;

 } TREE_EVENT_INFO_STRUCT;

 

 TREE_EVENT_INFO_STRUCT mTreeEventInfo[] = {

-  {&gTcgEventEntryHobGuid,             TREE_EVENT_LOG_FORMAT_TCG_1_2,      TREE_BOOT_HASH_ALG_SHA1,     0,                       TPM_ALG_SHA1},

+  {&gTcgEventEntryHobGuid,             TREE_EVENT_LOG_FORMAT_TCG_1_2},

 };

 

 BOOLEAN                 mImageInMemory  = FALSE;

@@ -129,28 +127,6 @@ EFI_PEI_NOTIFY_DESCRIPTOR           mNotifyList[] = {
 EFI_PEI_FIRMWARE_VOLUME_INFO_MEASUREMENT_EXCLUDED_PPI *mMeasurementExcludedFvPpi;

 

 /**

-  This function return hash algorithm from event log format.

-

-  @param[in]     EventLogFormat    Event log format.

-

-  @return hash algorithm.

-**/

-TPMI_ALG_HASH

-TrEEGetHashAlgoFromLogFormat (

-  IN      TREE_EVENT_LOG_FORMAT     EventLogFormat

-  )

-{

-  UINTN  Index;

-

-  for (Index = 0; Index < sizeof(mTreeEventInfo)/sizeof(mTreeEventInfo[0]); Index++) {

-    if (mTreeEventInfo[Index].LogFormat == EventLogFormat) {

-      return mTreeEventInfo[Index].TpmHashAlgo;

-    }

-  }

-  return TPM_ALG_SHA1;

-}

-

-/**

   This function get digest from digest list.

 

   @param HashAlg    digest algorithm

@@ -318,6 +294,10 @@ HashLogExtendEvent (
   EFI_STATUS                        Status;

   TPML_DIGEST_VALUES                DigestList;

 

+  if (GetFirstGuidHob (&gTpmErrorHobGuid) != NULL) {

+    return EFI_DEVICE_ERROR;

+  }

+

   Status = HashAndExtend (

              NewEventHdr->PCRIndex,

              HashData,

@@ -329,6 +309,16 @@ HashLogExtendEvent (
       Status = LogHashEvent (&DigestList, NewEventHdr, NewEventData);

     }

   }

+  

+  if (Status == EFI_DEVICE_ERROR) {

+    DEBUG ((EFI_D_ERROR, "HashLogExtendEvent - %r. Disable TPM.\n", Status));

+    BuildGuidHob (&gTpmErrorHobGuid,0);

+    REPORT_STATUS_CODE (

+      EFI_ERROR_CODE | EFI_ERROR_MINOR,

+      (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERROR)

+      );

+  }

+

   return Status;

 }

 

@@ -431,7 +421,6 @@ MeasureFvImage (
              &TcgEventHdr,

              (UINT8*) &FvBlob

              );

-  ASSERT_EFI_ERROR (Status);

 

   //

   // Add new FV into the measured FV list.

@@ -600,7 +589,6 @@ PeimEntryMP (
   

   if (PcdGet8 (PcdTpm2ScrtmPolicy) == 1) {

     Status = MeasureCRTMVersion ();

-    ASSERT_EFI_ERROR (Status);

   }

 

   Status = MeasureMainBios ();