ShellPkg: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17730 6f19259b-4bc3-4df7-8a09-765794883524

4 files changed, 38 insertions, 35 deletions

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
index 8faa54beee..deff42e049 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
@@ -2,7 +2,7 @@
   Main file for cp shell level 2 function.

 

   (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>

-  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -427,20 +427,20 @@ ValidateAndCopyFiles(
         // simple copy of a single file

         //

         if (Cwd != NULL) {

-          StrnCpy(DestPath, Cwd, PathSize/sizeof(CHAR16)-1);

+          StrCpyS(DestPath, PathSize / sizeof(CHAR16), Cwd);

         } else {

           ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_DIR_NF), gShellLevel2HiiHandle, L"cp", CleanFilePathStr);  

           FreePool (CleanFilePathStr);

           return (SHELL_INVALID_PARAMETER);

         }

         if (DestPath[StrLen(DestPath)-1] != L'\\' && CleanFilePathStr[0] != L'\\') {

-          StrnCat(DestPath, L"\\", PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+          StrCatS(DestPath, PathSize / sizeof(CHAR16), L"\\");

         } else if (DestPath[StrLen(DestPath)-1] == L'\\' && CleanFilePathStr[0] == L'\\') {

           ((CHAR16*)DestPath)[StrLen(DestPath)-1] = CHAR_NULL;

         }

-        StrnCat(DestPath, CleanFilePathStr, PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+        StrCatS(DestPath, PathSize/sizeof(CHAR16), CleanFilePathStr);

       } else {

-        StrnCpy(DestPath, CleanFilePathStr, PathSize/sizeof(CHAR16) -1);

+        StrCpyS(DestPath, PathSize/sizeof(CHAR16), CleanFilePathStr);

       }

     } else {

       //

@@ -455,44 +455,44 @@ ValidateAndCopyFiles(
          // Copy to the root of CWD

          //

         if (Cwd != NULL) {

-          StrnCpy(DestPath, Cwd, PathSize/sizeof(CHAR16) -1);

+          StrCpyS(DestPath, PathSize/sizeof(CHAR16), Cwd);

         } else {

           ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_DIR_NF), gShellLevel2HiiHandle, L"cp",  CleanFilePathStr); 

           FreePool(CleanFilePathStr);

           return (SHELL_INVALID_PARAMETER);

         }

         while (PathRemoveLastItem(DestPath));

-        StrnCat(DestPath, CleanFilePathStr+1, PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

-        StrnCat(DestPath, Node->FileName, PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+        StrCatS(DestPath, PathSize/sizeof(CHAR16), CleanFilePathStr+1);

+        StrCatS(DestPath, PathSize/sizeof(CHAR16), Node->FileName);

       } else if (StrStr(CleanFilePathStr, L":") == NULL) {

         if (Cwd != NULL) {

-          StrnCpy(DestPath, Cwd, PathSize/sizeof(CHAR16) -1);

+          StrCpyS(DestPath, PathSize/sizeof(CHAR16), Cwd);

         } else {

           ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_DIR_NF), gShellLevel2HiiHandle, L"cp", CleanFilePathStr);  

           FreePool(CleanFilePathStr);

           return (SHELL_INVALID_PARAMETER);

         }

         if (DestPath[StrLen(DestPath)-1] != L'\\' && CleanFilePathStr[0] != L'\\') {

-          StrnCat(DestPath, L"\\", PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+          StrCatS(DestPath, PathSize/sizeof(CHAR16), L"\\");

         } else if (DestPath[StrLen(DestPath)-1] == L'\\' && CleanFilePathStr[0] == L'\\') {

           ((CHAR16*)DestPath)[StrLen(DestPath)-1] = CHAR_NULL;

         }

-        StrnCat(DestPath, CleanFilePathStr, PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+        StrCatS(DestPath, PathSize/sizeof(CHAR16), CleanFilePathStr);

         if (CleanFilePathStr[StrLen(CleanFilePathStr)-1] != L'\\' && Node->FileName[0] != L'\\') {

-          StrnCat(DestPath, L"\\", PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+          StrCatS(DestPath, PathSize/sizeof(CHAR16), L"\\");

         } else if (CleanFilePathStr[StrLen(CleanFilePathStr)-1] == L'\\' && Node->FileName[0] == L'\\') {

           ((CHAR16*)DestPath)[StrLen(DestPath)-1] = CHAR_NULL;

         }

-        StrnCat(DestPath, Node->FileName, PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+        StrCatS(DestPath, PathSize/sizeof(CHAR16), Node->FileName);

 

       } else {

-        StrnCpy(DestPath, CleanFilePathStr, PathSize/sizeof(CHAR16) -1);

+        StrCpyS(DestPath, PathSize/sizeof(CHAR16), CleanFilePathStr);

         if (CleanFilePathStr[StrLen(CleanFilePathStr)-1] != L'\\' && Node->FileName[0] != L'\\') {

-          StrnCat(DestPath, L"\\", PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+          StrCatS(DestPath, PathSize/sizeof(CHAR16), L"\\");

         } else if (CleanFilePathStr[StrLen(CleanFilePathStr)-1] == L'\\' && Node->FileName[0] == L'\\') {

           ((CHAR16*)CleanFilePathStr)[StrLen(CleanFilePathStr)-1] = CHAR_NULL;

         }

-        StrnCat(DestPath, Node->FileName, PathSize/sizeof(CHAR16) - StrLen(DestPath) -1);

+        StrCatS(DestPath, PathSize/sizeof(CHAR16), Node->FileName);

       }

     }

     

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
index c025cebe56..40ba00b493 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
@@ -2,7 +2,7 @@
   Main file for mv shell level 2 function.

 

   (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>

-  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -187,7 +187,7 @@ GetDestinationLocation(
     if (DestPath == NULL) {

       return (SHELL_OUT_OF_RESOURCES);

     }

-    StrCpy(DestPath, Cwd);

+    StrCpyS(DestPath, StrSize(Cwd) / sizeof(CHAR16), Cwd);

     while (PathRemoveLastItem(DestPath)) ;

 

     //

@@ -220,13 +220,13 @@ GetDestinationLocation(
         ShellCloseFileMetaArg(&DestList);

         return (SHELL_OUT_OF_RESOURCES);

       }

-      StrCpy(DestPath, Cwd);

+      StrCpyS(DestPath, NewSize / sizeof(CHAR16), Cwd);

       if (DestPath[StrLen(DestPath)-1] != L'\\' && DestParameter[0] != L'\\') {

-        StrCat(DestPath, L"\\");

+        StrCatS(DestPath, NewSize / sizeof(CHAR16), L"\\");

       } else if (DestPath[StrLen(DestPath)-1] == L'\\' && DestParameter[0] == L'\\') {

         ((CHAR16*)DestPath)[StrLen(DestPath)-1] = CHAR_NULL;

       }

-      StrCat(DestPath, DestParameter);

+      StrCatS(DestPath, NewSize / sizeof(CHAR16), DestParameter);

     } else {

       ASSERT(DestPath == NULL);

       DestPath = StrnCatGrow(&DestPath, NULL, DestParameter, 0);

@@ -256,8 +256,8 @@ GetDestinationLocation(
         ShellCloseFileMetaArg(&DestList);

         return (SHELL_OUT_OF_RESOURCES);

       }

-      StrCpy(DestPath, Node->FullName);

-      StrCat(DestPath, L"\\");

+      StrCpyS(DestPath, (StrSize(Node->FullName)+sizeof(CHAR16)) / sizeof(CHAR16), Node->FullName);

+      StrCatS(DestPath, (StrSize(Node->FullName)+sizeof(CHAR16)) / sizeof(CHAR16), L"\\");

     } else {

       //

       // cant move multiple files onto a single file.

@@ -351,11 +351,11 @@ CreateFullDestPath(
     return (EFI_OUT_OF_RESOURCES);

   }

 

-  StrnCpy(*FullDestPath, *DestPath, Size / sizeof(CHAR16) - 1);

+  StrCpyS(*FullDestPath, Size / sizeof(CHAR16), *DestPath);

   if ((*FullDestPath)[StrLen(*FullDestPath)-1] != L'\\' && FileName[0] != L'\\') {

-    StrnCat(*FullDestPath, L"\\",Size / sizeof(CHAR16) - 1 - StrLen(*FullDestPath));

+    StrCatS(*FullDestPath, Size / sizeof(CHAR16), L"\\");

   }

-  StrnCat(*FullDestPath, FileName, Size / sizeof(CHAR16) - 1 - StrLen(*FullDestPath));

+  StrCatS(*FullDestPath, Size / sizeof(CHAR16), FileName);

 

   return (EFI_SUCCESS);

 }

@@ -403,10 +403,10 @@ MoveWithinFileSystems(
   } else {

     CopyMem(NewFileInfo, Node->Info, SIZE_OF_EFI_FILE_INFO);

     if (DestPath[0] != L'\\') {

-      StrCpy(NewFileInfo->FileName, L"\\");

-      StrCat(NewFileInfo->FileName, DestPath);

+      StrCpyS(NewFileInfo->FileName, (NewSize - SIZE_OF_EFI_FILE_INFO) / sizeof(CHAR16), L"\\");

+      StrCatS(NewFileInfo->FileName, (NewSize - SIZE_OF_EFI_FILE_INFO) / sizeof(CHAR16), DestPath);

     } else {

-      StrCpy(NewFileInfo->FileName, DestPath);

+      StrCpyS(NewFileInfo->FileName, (NewSize - SIZE_OF_EFI_FILE_INFO) / sizeof(CHAR16), DestPath);

     }

     Length = StrLen(NewFileInfo->FileName);

     if (Length > 0) {

@@ -419,7 +419,7 @@ MoveWithinFileSystems(
         //

         NewFileInfo->FileName[Length] = CHAR_NULL;

       }

-      StrCat(NewFileInfo->FileName, Node->FileName);

+      StrCatS(NewFileInfo->FileName, (NewSize - SIZE_OF_EFI_FILE_INFO) / sizeof(CHAR16), Node->FileName);

     }

     NewFileInfo->Size = SIZE_OF_EFI_FILE_INFO + StrSize(NewFileInfo->FileName);

 

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c
index e4176adfe0..a53a88c237 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c
@@ -2,7 +2,7 @@
   Main file for attrib shell level 2 function.

 

   (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>

-  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -132,9 +132,9 @@ CascadeDelete(
           if (TempName == NULL) {

             ShellStatus = SHELL_OUT_OF_RESOURCES;

           } else {

-            StrnCpy(TempName, Node->FullName, NewSize/sizeof(CHAR16) -1);

+            StrCpyS(TempName, NewSize/sizeof(CHAR16), Node->FullName);

             TempName[StrStr(TempName, L":")+1-TempName] = CHAR_NULL;

-            StrnCat(TempName, Node2->FullName, NewSize/sizeof(CHAR16) -1 - StrLen(TempName));

+            StrCatS(TempName, NewSize/sizeof(CHAR16), Node2->FullName);

             FreePool((VOID*)Node2->FullName);

             Node2->FullName = TempName;

 

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Vol.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Vol.c
index 39b8ad9ec8..a6f0296d76 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Vol.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Vol.c
@@ -2,7 +2,7 @@
   Main file for vol shell level 2 function.

 

   (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>

-  Copyright (c) 2011 - 2014, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -120,7 +120,10 @@ HandleVol(
       } 

     }

     if (SysInfo != NULL) {

-      StrnCpy ((CHAR16 *) SysInfo->VolumeLabel, Name, (Size1 > Size2?Size1/sizeof(CHAR16):Size2/sizeof(CHAR16))-1);

+      StrCpyS ( (CHAR16 *) SysInfo->VolumeLabel, 

+                  (Size1>Size2? Size1/sizeof(CHAR16) : Size2/sizeof(CHAR16)), 

+                  Name

+                  );

       SysInfo->Size = SIZE_OF_EFI_FILE_SYSTEM_INFO + Size1;

       Status = EfiFpHandle->SetInfo(

         EfiFpHandle,