diff options
| author | Qiu Shumin <shumin.qiu@intel.com> | 2015-12-13 08:44:49 +0000 |
|---|---|---|
| committer | shenshushi <shenshushi@Edk2> | 2015-12-13 08:44:49 +0000 |
| commit | 02d3482574ed2b0b5435563c234563bea2167634 (patch) | |
| tree | a451eeadeee983f2aba69bfa3ecb0224abd525b2 /ShellPkg | |
| parent | 898378c2be038bfbee21a8dd284a3dc3c5bb8f5e (diff) | |
| download | edk2-platforms-02d3482574ed2b0b5435563c234563bea2167634.tar.xz | |
ShellPkg: Initialize the local pointer to avoid potential suspicious dereference.
1. Initialize the local pointer 'HandleBuffer'.
2. When 'LocateHandleBuffer' return error 'HandleBuffer' is expected unchanged, add code make sure this.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19229 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ShellPkg')
| -rw-r--r-- | ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c index 3f08cc84dc..7b26e4d27f 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c @@ -317,6 +317,7 @@ ShellMmLocateIoProtocol ( }
*PciRootBridgeIo = NULL;
+ HandleBuffer = NULL;
Status = gBS->LocateHandleBuffer (
ByProtocol,
&gEfiPciRootBridgeIoProtocolGuid,
@@ -324,7 +325,7 @@ ShellMmLocateIoProtocol ( &HandleCount,
&HandleBuffer
);
- if (EFI_ERROR (Status) || (HandleCount == 0)) {
+ if (EFI_ERROR (Status) || (HandleCount == 0) || (HandleBuffer == NULL)) {
return FALSE;
}
|