This revision can only work with Intel(c) UDK Debugger Tool version 1.3 or greater. Detailed change log is as below:

1. Add DebugAgentPei driver to initialize Debug Agent in PEI phase.
   Add DebugAgentDxe driver to initialize Debug Agent in DXE phase.
   DebugAgentDxe driver could be loaded and unloaded in shell.
2. Update the SourceLevelDebugPkg so that the debug agent can be initialized in any phase: SEC, PEI or DXE.
3. Add an enhanced retry algorithm that provides a robust connection when data loss happens in the debug channel.
4. Clear DR7 register in exception handler.
5. Set the default serial port parameter to 0 instead of PCDs.
6. Build pointer of Mailbox in HOB instead of Mailbox itself, since HOB may be moved at DXE entry point function.
7. Raise TPL to prevent recursion from EFI timer interrupts in SerialIo.c.
8. Add one spin lock for accessing Mailbox when MP debugging supported.
9. Use more non-NULL library instances in SourceLevelDebugPkg DSC file, thus DebugAgentDxe.efi built from SourceLevelDebugPkg could work in shell.
10.Separate all operations about IDT table entry from SecDebugAgentLib.c into DebugAgent\DebugAgentCommon's arch sub-directory.
11.Enhance Debug Agent to avoid breaking by hardware SMI during DXE debugging phase.
12.Add supporting on mode switch code debugging.
13.Remove reset Host Controller operation in DebugCommunicationLibUsb.c to avoid impacting EDKII usb stack.
14.Fix debug timer interrupt missing issue after back from legacy code.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14083 6f19259b-4bc3-4df7-8a09-765794883524

2 files changed, 12 insertions, 13 deletions

diff --git a/SourceLevelDebugPkg/Include/ImageDebugSupport.h b/SourceLevelDebugPkg/Include/ImageDebugSupport.h
index 68299857a6..511a12ce27 100644
--- a/SourceLevelDebugPkg/Include/ImageDebugSupport.h
+++ b/SourceLevelDebugPkg/Include/ImageDebugSupport.h
@@ -2,7 +2,7 @@
   Public include file for Debug Agent Library instance and PE/COFF Extra

   Action Library instance.

 

-  Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -19,6 +19,7 @@
 #define IO_PORT_BREAKPOINT_ADDRESS  0x84

 #define IMAGE_LOAD_SIGNATURE        SIGNATURE_32('L','O','A','D')

 #define IMAGE_UNLOAD_SIGNATURE      SIGNATURE_32('U','N','L','O')

+#define AGENT_HANDLER_SIGNATURE     SIGNATURE_32('A','G','T','H')

 

 #define DEBUG_AGENT_IMAGE_WAIT      0x00

 #define DEBUG_AGENT_IMAGE_CONTINUE  0x01

diff --git a/SourceLevelDebugPkg/Include/TransferProtocol.h b/SourceLevelDebugPkg/Include/TransferProtocol.h
index bb7b07b4e2..53e9f7cf36 100644
--- a/SourceLevelDebugPkg/Include/TransferProtocol.h
+++ b/SourceLevelDebugPkg/Include/TransferProtocol.h
@@ -2,7 +2,7 @@
   Transfer protocol defintions used by debug agent and host. It is only

   intended to be used by Debug related module implementation.

 

-  Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -21,25 +21,19 @@
 //

 // Current revision of transfer protocol

 //

-#define DEBUG_AGENT_REVISION            ((0 << 16) | 02)

+#define DEBUG_AGENT_REVISION            ((0 << 16) | 03)

 #define DEBUG_AGENT_CAPABILITIES        0

 

 //

-// Definitions for break command.

-//

-#define DEBUG_STARTING_SYMBOL_BREAK         (0xFC)

-

-//

 // Definitions for attach command

 //

-#define DEBUG_STARTING_SYMBOL_ATTACH        (0xFA)

+#define DEBUG_STARTING_SYMBOL_ATTACH    (0xFA)

 

 //

 // Definition for starting symbol of a normal debug packet. Choose a non-ASCII to avoid conflict with other serial output.

 //

 #define DEBUG_STARTING_SYMBOL_NORMAL    (0xFE)

 

-

 #pragma pack(1)

 

 //

@@ -49,7 +43,8 @@ typedef struct {
   UINT8                      StartSymbol;

   UINT8                      Command;

   UINT8                      Length;    // Length of Debug Packet including header and payload in byte

-  UINT8                      CheckSum;

+  UINT8                      SequenceNo;

+  UINT16                     Crc;

 } DEBUG_PACKET_HEADER;

 

 //

@@ -86,6 +81,7 @@ typedef struct {
 #define DEBUG_COMMAND_DETACH                      (DEBUG_COMMAND_REQUEST | 0x16)

 #define DEBUG_COMMAND_CPUID                       (DEBUG_COMMAND_REQUEST | 0x17)

 #define DEBUG_COMMAND_SEARCH_SIGNATURE            (DEBUG_COMMAND_REQUEST | 0x18)

+#define DEBUG_COMMAND_HALT                        (DEBUG_COMMAND_REQUEST | 0x19)

 

 //

 // TARGET initiated commands

@@ -94,6 +90,7 @@ typedef struct {
 #define DEBUG_COMMAND_BREAK_POINT                 (DEBUG_COMMAND_REQUEST | 0x3E)

 #define DEBUG_COMMAND_MEMORY_READY                (DEBUG_COMMAND_REQUEST | 0x3D)

 #define DEBUG_COMMAND_PRINT_MESSAGE               (DEBUG_COMMAND_REQUEST | 0x3C)

+#define DEBUG_COMMAND_ATTACH_BREAK                (DEBUG_COMMAND_REQUEST | 0x3B)

 

 //

 // Response commands

@@ -308,8 +305,9 @@ typedef struct {
 //

 // Supported keys

 //

-#define DEBUG_AGENT_SETTING_SMM_ENTRY_BREAK     1

-#define DEBUG_AGENT_SETTING_PRINT_ERROR_LEVEL   2

+#define DEBUG_AGENT_SETTING_SMM_ENTRY_BREAK          1

+#define DEBUG_AGENT_SETTING_PRINT_ERROR_LEVEL        2

+#define DEBUG_AGENT_SETTING_BOOT_SCRIPT_ENTRY_BREAK  3

 //

 // Bitmask of print error level for debug message

 //