This revision can only work with Intel(c) UDK Debugger Tool version 1.2 or greater. Detailed change log is as below:

1. Define the transfer protocol revision mechanism. Increase the revision number to 0.2 and inform user to use the latest one when the HOST software is too old.
   New HOST software will implement logic to handle all other revision mismatch cases.
2. Define new debug message packet to print the debug agent trace information by debug port channel.
3. Add check sum mechanism in the communication protocol between TARGET/HOST.
4. Introduced one "try" mechanism to avoid Debug Agent crashed by some invalid HOST command.
5. Enable the late-attach feature: Change the break in from "!" to "\xFC". Add a new short symbol "\xFA" for attach and a new debug command for detach.
6. Support Terminal work on debug port by install EFI Serial IO protocol upon Debug Communication Library.
7. Enable CPUID feature.
8. Enable the hardware data breakpoint.
9. add handshake to improve usb debug cable identify stability issue.
10.Refine all the communication protocol packet to improve extensibility and debugging performance.
  a. Use 64bit for IO port address.
  b. Add additional Width field to READ_MEMORY/WRITE_MEMORY.
  c. Add SEARCH_SIGNATURE support to speed the symbol finding for late attach.
  d. Remove READ_GROUP register.
  e. Add READ_ALL_REGISTERS support (WinDbg always requests to read all registers).
11.Move AcquireDebugPortControl () in advance to fix resource collision on IpiSentByApFlag.
12.Fix IO break point does not work issue in PEI phase.
13.Avoid BSP/APs collision when they met break point at the same time.
14.Solve a bug of calculating debug handle in sec phase.
15.Use mailbox content at Dxe phase but not clear it and reinitialize again.
16.Fix FP/MMX/XMM/IO/MSR access issue in both Gdb and WinDbg.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13437 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 40 insertions, 16 deletions

diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c
index cc49dc0a59..f8e3f6c1ab 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c
@@ -1,7 +1,7 @@
 /** @file

   Debug Agent library implementition for Dxe Core and Dxr modules.

 

-  Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

   which accompanies this distribution.  The full text of the license may be found at

@@ -15,13 +15,9 @@
 #include "DxeDebugAgentLib.h"

 

 DEBUG_AGENT_MAILBOX          mMailbox;

-

 DEBUG_AGENT_MAILBOX          *mMailboxPointer;

-

 IA32_IDT_GATE_DESCRIPTOR     mIdtEntryTable[33];

-

-BOOLEAN                      mConfigurationTableNeeded = FALSE;

-

+BOOLEAN                      mDxeCoreFlag               = FALSE;

 CONST BOOLEAN                MultiProcessorDebugSupport = TRUE;

 

 /**

@@ -31,8 +27,7 @@ CONST BOOLEAN                MultiProcessorDebugSupport = TRUE;
   @param[in]  ImageHandle   The firmware allocated handle for the EFI image.

   @param[in]  SystemTable   A pointer to the EFI System Table.

 

-  @retval  RETURN_SUCCESS            Allocate the global memory space to store guid and function tables.

-  @retval  RETURN_OUT_OF_RESOURCES   No enough memory to allocated.

+  @retval  RETURN_SUCCESS   Allocate the global memory space to store guid and function tables.

 

 **/

 RETURN_STATUS

@@ -44,11 +39,34 @@ DxeDebugAgentLibConstructor (
 {

   EFI_STATUS                  Status;

   EFI_PHYSICAL_ADDRESS        Address;

+  EFI_EVENT                   Event;

+  VOID                        *EventRegistration;

 

-  if (!mConfigurationTableNeeded) {

+  if (!mDxeCoreFlag) {

     return RETURN_SUCCESS;

   }

 

+  Status = gBS->CreateEvent (

+                  EVT_NOTIFY_SIGNAL,

+                  TPL_CALLBACK,

+                  InstallSerialIoNotification,

+                  NULL,

+                  &Event

+                  );

+  ASSERT_EFI_ERROR (Status);

+

+  //

+  // Register for protocol notifications on this event

+  //

+

+  Status = gBS->RegisterProtocolNotify (

+                  &gEfiPcdProtocolGuid,

+                  Event,

+                  &EventRegistration

+                  );

+

+  ASSERT_EFI_ERROR (Status);

+

   Address = 0;

   Status = gBS->AllocatePages (

                   AllocateAnyPages,

@@ -56,9 +74,7 @@ DxeDebugAgentLibConstructor (
                   EFI_SIZE_TO_PAGES (sizeof (DEBUG_AGENT_MAILBOX)),

                   &Address

                   );

-  if (EFI_ERROR (Status)) {

-    return Status;

-  }

+  ASSERT_EFI_ERROR (Status);

 

   CopyMem (

     (UINT8 *) (UINTN) Address,

@@ -68,7 +84,10 @@ DxeDebugAgentLibConstructor (
 

   mMailboxPointer = (DEBUG_AGENT_MAILBOX *) (UINTN) Address;

 

-  return gBS->InstallConfigurationTable (&gEfiDebugAgentGuid, (VOID *) mMailboxPointer);

+  Status = gBS->InstallConfigurationTable (&gEfiDebugAgentGuid, (VOID *) mMailboxPointer);

+  ASSERT_EFI_ERROR (Status);

+  

+  return Status;

 }

 

 /**

@@ -168,8 +187,13 @@ InitializeDebugAgent (
     //

     // Try to get Mailbox from GUIDed HOB.

     //

-    mConfigurationTableNeeded = TRUE;

+    mDxeCoreFlag = TRUE;

     Mailbox = GetMailboxFromHob (Context);

+    

+    //

+    // Clear Break CPU index value

+    //

+    mDebugMpContext.BreakAtCpuIndex = (UINT32) -1;

 

   } else if (InitFlag == DEBUG_AGENT_INIT_DXE_AP) {

 

@@ -189,7 +213,6 @@ InitializeDebugAgent (
     // If Mailbox exists, copy it into one global variable.

     //

     CopyMem (&mMailbox, Mailbox, sizeof (DEBUG_AGENT_MAILBOX));

-    mMailbox.DebugPortHandle = 0;

   } else {

     //

     // If Mailbox not exists, used the local Mailbox.

@@ -207,6 +230,7 @@ InitializeDebugAgent (
   if (IdtEntryCount < 33) {

     Idtr.Limit = (UINT16) (sizeof (IA32_IDT_GATE_DESCRIPTOR) * 33 - 1);

     Idtr.Base  = (UINTN) &mIdtEntryTable;

+    ZeroMem (&mIdtEntryTable, Idtr.Limit + 1);

     AsmWriteIdtr ((IA32_DESCRIPTOR *) &Idtr);

   }

 

@@ -218,7 +242,7 @@ InitializeDebugAgent (
   //

   // Initialize debug communication port

   //

-  mMailboxPointer->DebugPortHandle = (UINT64) (UINTN)DebugPortInitialize (NULL, NULL);

+  mMailboxPointer->DebugPortHandle = (UINT64) (UINTN)DebugPortInitialize ((VOID *)(UINTN)mMailbox.DebugPortHandle, NULL);

 

   InitializeSpinLock (&mDebugMpContext.MpContextSpinLock);

   InitializeSpinLock (&mDebugMpContext.DebugPortSpinLock);