diff options
author | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2017-03-14 19:52:11 +0000 |
---|---|---|
committer | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2017-03-15 19:36:10 +0000 |
commit | 0985beff2ce5e9f41e39e1900a8d19d22975d733 (patch) | |
tree | c5ae8204c0f70043edc5f906684b8a1a9b860b07 /StdLibPrivateInternalFiles | |
parent | 7e1bc8cdb387430de34cf46a3da14b09dd2e84e2 (diff) | |
download | edk2-platforms-0985beff2ce5e9f41e39e1900a8d19d22975d733.tar.xz |
ArmPkg/UncachedMemoryAllocationLib: set XP bit via CPU arch protocol
Commit e7b24ec9785d ("ArmPkg/UncachedMemoryAllocationLib: map uncached
allocations non-executable") adds code that manipulates the GCD memory
space attributes of a newly allocated uncached region without checking
whether this region expose these attributes in its capabilities mask.
Given that the intent is to remove executable permissions from the region,
this is a fairly pointless exercise to begin with, regardless of whether
it is correct or not. The reason is that RO/XP memory attributes in the
GCD memory space map or the UEFI memory map are completely disconnected
from the actual mapping permissions used in the page tables.
So instead, invoke the CPU arch protocol directly, and add the non-exec
attributes in the page tables directly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
Diffstat (limited to 'StdLibPrivateInternalFiles')
0 files changed, 0 insertions, 0 deletions