diff options
| author | Gabe Black <gabeblack@google.com> | 2018-03-16 00:53:42 -0700 |
|---|---|---|
| committer | Gabe Black <gabeblack@google.com> | 2018-03-22 19:46:54 +0000 |
| commit | e09a581188cbc2e1ff989d500399d0125a4dbc07 (patch) | |
| tree | 07bae67d95240b83dd5024785839b454c3a9720c | |
| parent | d28bc0f946fcb7d6ad90b74f917db9fa9d311191 (diff) | |
| download | gem5-e09a581188cbc2e1ff989d500399d0125a4dbc07.tar.xz | |
hsail: Get rid of an inert private member of StorageSpace.
The "segment" private element in this class was only ever set to zero
on construction, and then used to index into a list of segment names
to get the string "none" in a DPRINTF. If debugging was turned off,
there would be no consumers of that variable, and that upset g++. This
change removes the essentially useless variable, and also that bit of
text in the DPRINTF.
Change-Id: I3f85db4af5f0678768243daf84b8d698350af931
Reviewed-on: https://gem5-review.googlesource.com/9221
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
| -rw-r--r-- | src/gpu-compute/hsail_code.cc | 4 | ||||
| -rw-r--r-- | src/gpu-compute/hsail_code.hh | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/src/gpu-compute/hsail_code.cc b/src/gpu-compute/hsail_code.cc index 59faa67e9..99f4b3896 100644 --- a/src/gpu-compute/hsail_code.cc +++ b/src/gpu-compute/hsail_code.cc @@ -305,8 +305,8 @@ StorageSpace::addSymbol(const BrigDirectiveVariable *sym, nextOffset = offset + size; - DPRINTF(HSAILObject, "Adding %s SYMBOL %s size %d offset 0x%x, init: %d\n", - segmentNames[segment], sym_name, size, offset, sym->init); + DPRINTF(HSAILObject, "Adding SYMBOL %s size %d offset %#x, init: %d\n", + sym_name, size, offset, sym->init); StorageElement* se = new StorageElement(sym_name, offset, size, sym); elements.push_back(se); diff --git a/src/gpu-compute/hsail_code.hh b/src/gpu-compute/hsail_code.hh index d9fbcc577..991946197 100644 --- a/src/gpu-compute/hsail_code.hh +++ b/src/gpu-compute/hsail_code.hh @@ -245,11 +245,9 @@ class StorageSpace DirVarToSE_map elements_by_brigptr; uint64_t nextOffset; - Brig::BrigSegment segment; public: - StorageSpace(Brig::BrigSegment _class) - : nextOffset(0), segment(_class) + StorageSpace(Brig::BrigSegment _class) : nextOffset(0) { } |