diff options
| author | Daniel R. Carvalho <odanrc@yahoo.com.br> | 2018-02-06 11:24:30 +0100 |
|---|---|---|
| committer | Daniel Carvalho <mr.danrc@gmail.com> | 2018-02-06 16:13:27 +0000 |
| commit | 0f2e20c80aa6bbc87f3791a8fdf81489ad501a40 (patch) | |
| tree | 5364ae00339d69c72544e38973eeb0d735736e59 | |
| parent | ecee328c9244504f616a3b8cd352fca3d3e4b6e7 (diff) | |
| download | gem5-0f2e20c80aa6bbc87f3791a8fdf81489ad501a40.tar.xz | |
mem-cache: Remove extra numSets zero check.
numSets is unsigned, so it cannot be lower than 0. Besides, isPowerOf2(0)
is false by definition (and implemmentation*), so there is no need for the
double check.
* As presented in base/intmath.hh
Change-Id: I3f6296694a937434feddc7ed21f11c2a6fdfc5a9
Reviewed-on: https://gem5-review.googlesource.com/7901
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
| -rw-r--r-- | src/mem/cache/tags/base_set_assoc.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mem/cache/tags/base_set_assoc.cc b/src/mem/cache/tags/base_set_assoc.cc index ea74c97df..ba9447525 100644 --- a/src/mem/cache/tags/base_set_assoc.cc +++ b/src/mem/cache/tags/base_set_assoc.cc @@ -63,7 +63,7 @@ BaseSetAssoc::BaseSetAssoc(const Params *p) if (blkSize < 4 || !isPowerOf2(blkSize)) { fatal("Block size must be at least 4 and a power of 2"); } - if (numSets <= 0 || !isPowerOf2(numSets)) { + if (!isPowerOf2(numSets)) { fatal("# of sets must be non-zero and a power of 2"); } if (assoc <= 0) { |