summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRohit Kurup <rohit.kurup@arm.com>2017-06-27 10:37:46 +0100
committerAndreas Sandberg <andreas.sandberg@arm.com>2017-07-10 08:31:10 +0000
commit999c14894fd39367443656bd9dbb61fd8f3c7075 (patch)
tree50c9a70a07f3d6e7a610e1cca43f0afeb4a7524b
parentfd5b754974dd7b76a0b8798eb206a4c76a311cee (diff)
downloadgem5-999c14894fd39367443656bd9dbb61fd8f3c7075.tar.xz
dev: Fix OnIdle test in DmaReadFifo
OnIdle() is never called since DMA active check is completely opposite to what it should be. old active status should be 'true' and new active status should be false for OnIdle to be called Change-Id: I94eca50edbe96113190837c7f6e50a0d061158a6 Reported-by: Rohit Kurup <rohit.kurup@arm.com> Signed-off-by: Rohit Kurup <rohit.kurup@arm.com> Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com> Reviewed-on: https://gem5-review.googlesource.com/3966 Reviewed-by: Michael LeBeane <Michael.Lebeane@amd.com>
-rw-r--r--src/dev/dma_device.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/dev/dma_device.cc b/src/dev/dma_device.cc
index a78819a3e..f6f751c05 100644
--- a/src/dev/dma_device.cc
+++ b/src/dev/dma_device.cc
@@ -438,7 +438,7 @@ DmaReadFifo::dmaDone()
handlePending();
resumeFill();
- if (!old_active && isActive())
+ if (old_active && !isActive())
onIdle();
}