diff options
| author | Isaac Sánchez Barrera <isaac.sanchez@bsc.es> | 2019-11-15 16:17:23 +0100 |
|---|---|---|
| committer | Isaac Sánchez Barrera <isaac.sanchez@bsc.es> | 2019-11-18 11:10:21 +0000 |
| commit | 7e19b26f503435f07dc4b5675061facc521b8c91 (patch) | |
| tree | 074ff6c39997dd56ef6b125f08cc7231952d6f74 | |
| parent | ccb3c75fabb36f293793a65d2b8fe05fc899656a (diff) | |
| download | gem5-7e19b26f503435f07dc4b5675061facc521b8c91.tar.xz | |
mem-cache: Initialize all members of `QueuedPrefetcher::DeferredPacket`.
Members `tc` and `ongoingTranslation` were uninitialized in the constructor for
`QueuedPrefetcher::DeferredPacket`. If `ongoingTranslation` is not initialized to
`false` by default, some translation requests from queued prefetchers are not
properly handled and executions are nondeterministic.
Change-Id: Ia278f9e74847d6b847984d47f6a45643bae57794
Signed-off-by: Isaac Sánchez Barrera <isaac.sanchez@bsc.es>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/22844
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
| -rw-r--r-- | src/mem/cache/prefetch/queued.hh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mem/cache/prefetch/queued.hh b/src/mem/cache/prefetch/queued.hh index ae4c5e4ad..adcd255ba 100644 --- a/src/mem/cache/prefetch/queued.hh +++ b/src/mem/cache/prefetch/queued.hh @@ -80,7 +80,8 @@ class QueuedPrefetcher : public BasePrefetcher */ DeferredPacket(QueuedPrefetcher *o, PrefetchInfo const &pfi, Tick t, int32_t prio) : owner(o), pfInfo(pfi), tick(t), pkt(nullptr), - priority(prio), translationRequest() { + priority(prio), translationRequest(), tc(nullptr), + ongoingTranslation(false) { } bool operator>(const DeferredPacket& that) const |